Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

Previous thread: [patch 1/4] mempolicy: convert MPOL constants to enum by David Rientjes on Monday, February 11, 2008 - 8:30 am. (78 messages)

Next thread: Re: 2.6.24-git2: Oracle 11g VKTM process enters R state on startup and is unkillable [still broken in 2.6.25-rc1] by Alessandro Suardi on Monday, February 11, 2008 - 9:20 am. (13 messages)
From: Jan-Bernd Themann
Date: Monday, February 11, 2008 - 8:57 am

Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>


---
 Hi,

 this is the modified version with EXPORT_SYMBOL_GPL

 Regards,
 Jan-Bernd


 drivers/base/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..f5a0bf1 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL_GPL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL_GPL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
-- 
1.5.2

--

From: Sam Ravnborg
Date: Monday, February 11, 2008 - 9:02 am

Can you please add proper kernel-doc formatted comments
when you export a symbol so others can get a clue
what the exported function is supposed to do.

	Sam
--

From: Dave Hansen
Date: Monday, February 11, 2008 - 9:04 am

Could you post this with the new users as well so we can make sure
they're not abusing this in some way?

-- Dave

--

Previous thread: [patch 1/4] mempolicy: convert MPOL constants to enum by David Rientjes on Monday, February 11, 2008 - 8:30 am. (78 messages)

Next thread: Re: 2.6.24-git2: Oracle 11g VKTM process enters R state on startup and is unkillable [still broken in 2.6.25-rc1] by Alessandro Suardi on Monday, February 11, 2008 - 9:20 am. (13 messages)