Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier

Previous thread: [PATCH] [2/8] CPA: Flush the caches when setting pages not present by Andi Kleen on Monday, February 11, 2008 - 5:34 am. (37 messages)

Next thread: [PATCH] [0/8] Misc CPA patchkit by Andi Kleen on Monday, February 11, 2008 - 5:50 am. (21 messages)
To: Greg KH <greg@...>
Cc: Jan-Bernd Themann <themann@...>, Thomas Klein <osstklei@...>, netdev <netdev@...>, linux-kernel <linux-kernel@...>, linux-ppc <linuxppc-dev@...>, Christoph Raisch <raisch@...>
Date: Monday, February 11, 2008 - 5:49 am

Drivers like eHEA need memory notifiers in order to
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>

---
Hi Greg,

are you the right person to address this patch to?

Regards,
Jan-Bernd

drivers/base/memory.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..1e1bd4c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
{
return blocking_notifier_chain_register(&memory_chain, nb);
}
+EXPORT_SYMBOL(register_memory_notifier);

void unregister_memory_notifier(struct notifier_block *nb)
{
blocking_notifier_chain_unregister(&memory_chain, nb);
}
+EXPORT_SYMBOL(unregister_memory_notifier);

/*
* register_memory - Setup a sysfs device for a memory block
--
1.5.2

--

To: Jan-Bernd Themann <ossthema@...>
Cc: Greg KH <greg@...>, Jan-Bernd Themann <themann@...>, Thomas Klein <osstklei@...>, netdev <netdev@...>, linux-kernel <linux-kernel@...>, linux-ppc <linuxppc-dev@...>, Christoph Raisch <raisch@...>
Date: Monday, February 11, 2008 - 6:12 am

Is there a particular reason these can't be GPL?

-- Dave

--

To: Dave Hansen <haveblue@...>
Cc: Greg KH <greg@...>, Jan-Bernd Themann <themann@...>, Thomas Klein <osstklei@...>, netdev <netdev@...>, linux-kernel <linux-kernel@...>, linux-ppc <linuxppc-dev@...>, Christoph Raisch <raisch@...>
Date: Monday, February 11, 2008 - 6:47 am

I don't object to make them GPL. Greg, what do you think?

Regards,
Jan-Bernd

--

To: Jan-Bernd Themann <ossthema@...>
Cc: Dave Hansen <haveblue@...>, Jan-Bernd Themann <themann@...>, Thomas Klein <osstklei@...>, netdev <netdev@...>, linux-kernel <linux-kernel@...>, linux-ppc <linuxppc-dev@...>, Christoph Raisch <raisch@...>
Date: Monday, February 11, 2008 - 11:22 am

They should be _GPL to match the rest of the driver core.

Care to resend this?

thanks,

greg k-h
--

Previous thread: [PATCH] [2/8] CPA: Flush the caches when setting pages not present by Andi Kleen on Monday, February 11, 2008 - 5:34 am. (37 messages)

Next thread: [PATCH] [0/8] Misc CPA patchkit by Andi Kleen on Monday, February 11, 2008 - 5:50 am. (21 messages)