Home » Mailing list archives » linux-kernel » 2008 » February » 11

[PATCH] [6/8] CPA: Remove BUG_ON for LRU/Compound pages

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <ak@...>
To: <tglx@...>, <mingo@...>, <linux-kernel@...>
Subject: [PATCH] [6/8] CPA: Remove BUG_ON for LRU/Compound pages
Date: Monday, February 11, 2008 - 5:50 am

New implementation does not use lru for anything so there is no need
to reject pages that are in the LRU. Similar for compound pages (which
were checked because they also use page->lru)

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86/mm/pageattr.c |    5 -----
 1 file changed, 5 deletions(-)

Index: linux/arch/x86/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr.c
+++ linux/arch/x86/mm/pageattr.c
@@ -545,7 +545,6 @@ static int __change_page_attr(unsigned l
 {
 	int do_split, err;
 	unsigned int level;
-	struct page *kpte_page;
 	pte_t *kpte;
 
 repeat:
@@ -553,10 +552,6 @@ repeat:
 	if (!kpte)
 		return -EINVAL;
 
-	kpte_page = virt_to_page(kpte);
-	BUG_ON(PageLRU(kpte_page));
-	BUG_ON(PageCompound(kpte_page));
-
 	if (level == PG_LEVEL_4K) {
 		pte_t new_pte, old_pte = *kpte;
 		pgprot_t new_prot = pte_pgprot(old_pte);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/8] Misc CPA patchkit, Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [8/8] CPA: Add statistics about state of direct mapp..., Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [7/8] CPA: Don't flush caches on CPUs that support s..., Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Arjan van de Ven, (Mon Feb 11, 11:04 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Mon Feb 11, 11:12 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Arjan van de Ven, (Mon Feb 11, 11:21 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Mon Feb 11, 11:27 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Siddha, Suresh B, (Mon Feb 11, 1:36 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Mon Feb 11, 1:58 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Siddha, Suresh B, (Mon Feb 11, 3:47 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Arjan van de Ven, (Mon Feb 11, 4:36 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Tue Feb 12, 4:45 am)
[PATCH] [6/8] CPA: Remove BUG_ON for LRU/Compound pages, Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [6/8] CPA: Remove BUG_ON for LRU/Compound pages, Thomas Gleixner, (Sun Feb 17, 10:07 am)
[PATCH] [5/8] CPA: Move pool allocation/free into separate f..., Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [4/8] CPA: Ifdef the cpa pool for DEBUG_PAGEALLOC, Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [3/8] CPA: Fix some incorrect comments in the debug ..., Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [2/8] CPA: Remove inline from static_protections, Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [2/8] CPA: Remove inline from static_protections, Ingo Molnar, (Mon Feb 11, 10:04 am)
[PATCH] [1/8] CPA: Remove my copyright notice, Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [1/8] CPA: Remove my copyright notice, Thomas Gleixner, (Mon Feb 11, 8:42 pm)