Home » Mailing list archives » linux-kernel » 2008 » February » 11

[PATCH] [3/8] CPA: Fix some incorrect comments in the debug pagealloc code

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <ak@...>
To: <tglx@...>, <mingo@...>, <linux-kernel@...>
Subject: [PATCH] [3/8] CPA: Fix some incorrect comments in the debug pagealloc code
Date: Monday, February 11, 2008 - 5:50 am

Even with the pool cpa in debug_pagealloc can fail (e.g. consider memory hotplug) 
Also the code does not clear PSE anymore as the comment claims.

Replace wrong comment with correct one.
Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/x86/mm/pageattr.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Index: linux/arch/x86/mm/pageattr.c
===================================================================
--- linux.orig/arch/x86/mm/pageattr.c
+++ linux/arch/x86/mm/pageattr.c
@@ -864,10 +864,7 @@ void kernel_map_pages(struct page *page,
 	if (!debug_pagealloc_enabled)
 		return;
 
-	/*
-	 * The return value is ignored - the calls cannot fail,
-	 * large pages are disabled at boot time:
-	 */
+	/* This can fail in theory but then you're out of luck */
 	if (enable)
 		__set_pages_p(page, numpages);
 	else
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/8] Misc CPA patchkit, Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [8/8] CPA: Add statistics about state of direct mapp..., Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [7/8] CPA: Don't flush caches on CPUs that support s..., Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Arjan van de Ven, (Mon Feb 11, 11:04 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Mon Feb 11, 11:12 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Arjan van de Ven, (Mon Feb 11, 11:21 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Mon Feb 11, 11:27 am)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Siddha, Suresh B, (Mon Feb 11, 1:36 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Mon Feb 11, 1:58 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Siddha, Suresh B, (Mon Feb 11, 3:47 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Arjan van de Ven, (Mon Feb 11, 4:36 pm)
Re: [PATCH] [7/8] CPA: Don't flush caches on CPUs that suppo..., Andi Kleen, (Tue Feb 12, 4:45 am)
[PATCH] [6/8] CPA: Remove BUG_ON for LRU/Compound pages, Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [6/8] CPA: Remove BUG_ON for LRU/Compound pages, Thomas Gleixner, (Sun Feb 17, 10:07 am)
[PATCH] [5/8] CPA: Move pool allocation/free into separate f..., Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [4/8] CPA: Ifdef the cpa pool for DEBUG_PAGEALLOC, Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [3/8] CPA: Fix some incorrect comments in the debug ..., Andi Kleen, (Mon Feb 11, 5:50 am)
[PATCH] [2/8] CPA: Remove inline from static_protections, Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [2/8] CPA: Remove inline from static_protections, Ingo Molnar, (Mon Feb 11, 10:04 am)
[PATCH] [1/8] CPA: Remove my copyright notice, Andi Kleen, (Mon Feb 11, 5:50 am)
Re: [PATCH] [1/8] CPA: Remove my copyright notice, Thomas Gleixner, (Mon Feb 11, 8:42 pm)