On Sunday 10 February 2008, Adrian McMenamin wrote:
quoted text > +static int dc_pad_connect(struct maple_device *mdev)
> +{
> + ...
> + if (data&(1<<i) && abs_bit[i] >=3D 0)
could use a few spaces in that first expression
quoted text > +/* allow the controller to be used */
> +static int probe_maple_controller(struct device *dev)
> +{
> + struct maple_device *mdev =3D to_maple_dev(dev);
> + struct maple_driver *mdrv =3D to_maple_driver(dev->driver);
> + int error;
> +
> + error =3D dc_pad_connect(mdev);
> + if (error)
> + return error;
> +
> + mdev->driver =3D mdrv;
> +
> + return 0;
> +}
> +
> +static struct maple_driver dc_pad_driver =3D {
> + .function =3D MAPLE_FUNC_CONTROLLER,
> + .connect =3D dc_pad_connect,
> + .disconnect =3D dc_pad_disconnect,
> + .drv =3D {
> + .name =3D "Dreamcast_controller",
> + .probe =3D probe_maple_controller,
> + },
> +};
no remove function ? looks like the probe() forces a connect, but there's =
no=20
remove() to force a disconnect ...
=2Dmike
