Cc: Ray Lee <ray-lk@...>, Ingo Molnar <mingo@...>, Sam Ravnborg <sam@...>, <linux-kernel@...>, Andrew Morton <akpm@...>, Thomas Gleixner <tglx@...>, Jason Wessel <jason.wessel@...>
Ok, so this is a pretty function after all the cleanups, but I actually
don't think that "if ((unsigned long)addr < TASK_SIZE)" is really even
asked for.
Why not let kgdb look at user memory? I'd argue that in a lot of cases, it
might be quite nice to do, to see what user arguments in memory are etc
etc (think things like futexes, where user memory contents really do
matter).
So I'd suggest getting rid of the whole "kgdb_{get|set}_mem()" functions,
and just using "probe_kernel_{read|write}()" directly instead.
(Not that I necessarily love those names either, but whatever..)
The TASK_SIZE checks make more sense in kgdb_validate_break_address() and
friends, where it actually does make sense to check that it's really a
*kernel* address.
But even there, I'm not sure if the right check is to compare against
TASK_SIZE, since kernel and user memory addresses can in theory be
distinct (that's why we have "set_fs()" historically, and while it's no
longer true on x86 and hasn't been in a long time, the kernel conceptually
allows it - see my previous reply about that whole get_fs/set_fs thing in
the definition of probe_kernel_read/write).
There's absolutely no reason to care about the alignment, since if you now
use "probe_kernel_read()", the sane thing to do is to just do
err = probe_kernel_read(tmp, mem, count);
if (!err) {
while (count > 0) {
buf = pack_hex_byte(buf, *tmp);
tmp++;
count--;
}
and you're all done. No?
Linus
--
