login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
10
Re: [3/6] kgdb: core
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Bartlomiej Zolnierkiewicz
Subject:
Re: [3/6] kgdb: core
Date: Sunday, February 10, 2008 - 12:20 pm
On Sunday 10 February 2008, Ingo Molnar wrote:
quoted text
> > * Marcin Slusarz <marcin.slusarz@gmail.com> wrote: > > > > + if (CACHE_FLUSH_IS_SAFE) { > > > + if (current->mm && addr < TASK_SIZE) { > > > + flush_cache_range(current->mm->mmap_cache, > > > + addr, addr + BREAK_INSTR_SIZE); > > > + } else { > > > + flush_icache_range(addr, addr + > > > + BREAK_INSTR_SIZE); > > > + } > > > + } > > unneeded braces (here and in many other places) > > this is a small detail, but you are wrong. These braces around > multi-line statements are unneded _for the compiler_, but are very much > wanted by humans. You'll see akpm, me and others reject/fix patches on a > routine basis that make this cleanliness mistake. Please watch out for > this when writing patches ;-) > > > if () > > else if () > > else > > > > will look better > > nope. I consciously avoid that construct because it's dangerous: it can > quite easily result in the wrong logic. Having _more_ braces than needed > by the compiler is a style error in only a single, special case.
however it can be still made to: if () { if () else } [ not fixed in v6 ] --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 12:13 am)
Re: [3/6] kgdb: core
, Sam Ravnborg
, (Sun Feb 10, 12:31 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 12:35 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 12:43 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 12:57 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 12:59 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 1:02 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 1:21 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 1:24 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 1:26 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 1:57 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 2:08 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 2:11 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 2:17 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 2:20 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 2:27 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 2:31 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 2:34 am)
Re: [3/6] kgdb: core
, Christoph Hellwig
, (Sun Feb 10, 2:34 am)
Re: [3/6] kgdb: core
, Marcin Slusarz
, (Sun Feb 10, 5:46 am)
Re: [3/6] kgdb: core
, Jesper Juhl
, (Sun Feb 10, 6:19 am)
Re: [3/6] kgdb: core
, Jan Kiszka
, (Sun Feb 10, 6:36 am)
Re: [3/6] kgdb: core
, Marcin Slusarz
, (Sun Feb 10, 7:00 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 9:43 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 9:46 am)
Re: [3/6] kgdb: core
, Ingo Molnar
, (Sun Feb 10, 10:02 am)
[patch] kgdb light, v6
, Ingo Molnar
, (Sun Feb 10, 10:17 am)
Re: [3/6] kgdb: core
, Bartlomiej Zolnierki ...
, (Sun Feb 10, 12:20 pm)
Re: [patch] kgdb light, v6
, Bartlomiej Zolnierki ...
, (Sun Feb 10, 12:43 pm)
Re: [patch] kgdb light, v6
, Bartlomiej Zolnierki ...
, (Sun Feb 10, 1:55 pm)
Re: [patch] kgdb light, v6
, Ingo Molnar
, (Sun Feb 10, 2:09 pm)
Re: [patch] kgdb light, v6
, Ingo Molnar
, (Sun Feb 10, 2:31 pm)
Re: [patch] kgdb light, v6
, Jan Kiszka
, (Sun Feb 10, 2:45 pm)
Re: [patch] kgdb light, v6
, Bartlomiej Zolnierki ...
, (Sun Feb 10, 3:14 pm)
Re: [patch] kgdb light, v6
, Bartlomiej Zolnierki ...
, (Sun Feb 10, 3:24 pm)
Re: [patch] kgdb light, v6
, Ingo Molnar
, (Sun Feb 10, 3:31 pm)
Re: [patch] kgdb light, v6
, Jan Kiszka
, (Sun Feb 10, 3:32 pm)
Re: [patch] kgdb light, v6
, Ingo Molnar
, (Sun Feb 10, 3:40 pm)
Re: [patch] kgdb light, v6
, Yinghai Lu
, (Sun Feb 10, 7:35 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Rusty Russell
Re: 2.6.22-rc3-mm1
Bill Fink
Re: [PATCH] net: add ability to clear stats via ethtool - e1000/pcnet32
Jeffrey V. Merkey
Re: Versioning file system
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Luben Tuikov
Re: Integration of SCST in the mainstream Linux kernel
git-commits-head
:
Linux Kernel Mailing List
V4L/DVB: tm6000: add special usb request to quit i2c tuner transfer
Linux Kernel Mailing List
OMAP: DSS2: SDI driver
Linux Kernel Mailing List
PCI: introduce pci_pcie_cap()
Linux Kernel Mailing List
drivers/acpi: use kasprintf
Linux Kernel Mailing List
PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation
linux-netdev
:
David Miller
Re: [2.6.30-rc3] powerpc: compilation error of mace module
Rafael J. Wysocki
Re: [PATCH] igb: fix kexec with igb
Patrick McHardy
Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
webmaster Maintenance
&#32852;&#31995;&#31995;&#32479;&#31649;&#29702;&#21592;
Krzysztof Oledzki
Re: Error: an inet prefix is expected rather than "0/0".
openbsd-misc
:
Ted Bullock
Re: Proliant DL380 G3 cannot get on network
Jack J. Woehr
Re: Real men don't attack straw men
Úlfar M. E. Johnson
installing openbsd in xen
Eric Furman
Re: Defending OpenBSD Performance
Tony Abernethy
Re: The Atheros story in much fewer words
git
:
Oliver Kullmann
Re: how to move with history?
Junio C Hamano
Re: [PATCH 2/3] git-add--interactive: remove hunk coalescing
Shawn O. Pearce
Re: Bugs in Gitosis
Alex Riesen
Re: git exclude patterns for directory
David Kastrup
Re: I'm a total push-over..
Colocation donated by:
Syndicate