Home » Mailing list archives » linux-kernel » 2008 » February » 10

[PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

Previous thread: [PATCH] drivers/media/video/em28xx/: Fix undefined symbol error with CONFIG_SND=N by S.Çağlar on Saturday, February 9, 2008 - 8:27 pm. (1 message)

Next thread: kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit by Niki Denev on Saturday, February 9, 2008 - 11:04 pm. (15 messages)
[view original message]
From: S.Çağlar
Subject: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
Date: Saturday, February 9, 2008 - 8:37 pm

Hi;

Following patch silents

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect

compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>

 drivers/mtd/ubi/vmt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..eafeaf0 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,7 @@ out_sysfs:
 	get_device(&vol->dev);
 	volume_sysfs_close(vol);
 out_gluebi:
-	ubi_destroy_gluebi(vol);
+	err = ubi_destroy_gluebi(vol);
 out_cdev:
 	cdev_del(&vol->cdev);
 out_mapping:

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--


[ message continues ]
[view original message]
From: Jiri Slaby
Subject: Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
Date: Sunday, February 10, 2008 - 1:39 am

I think this is not correct. You change the err which caused the failure. You 
change it even to 0 if it doesn't fail and the whole function will seem like 
non-failing.
--


[ message continues ]
[view original message]
From: S.Çağlar
Subject: Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
Date: Sunday, February 10, 2008 - 4:44 pm

Hi;


My bad, sorry for not looking carefully. Assuming a refactoring is not desired for just a compiler warning, is following acceptable (this kind of plain messages seems heavily used in vmt.c, so i'm again assuming its OK to use such style)?

commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) introduced the warning

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect


 drivers/mtd/ubi/vmt.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..46410f6 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,8 @@ out_sysfs:
 	get_device(&vol->dev);
 	volume_sysfs_close(vol);
 out_gluebi:
-	ubi_destroy_gluebi(vol);
+	if(ubi_destroy_gluebi(vol))
+		ubi_err("cannot destroy device");
 out_cdev:
 	cdev_del(&vol->cdev);
 out_mapping:


Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--


[ message continues ]
[view original message]
From: Artem Bityutskiy
Subject: Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
Date: Tuesday, February 12, 2008 - 2:33 am

Thanks, applied to UBI git with Minor changes, will send git-pull request
shortly.

Please, note that my e-mail address is not dedekind@linutronix.de,
see MAINTAINERS.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--


[ message continues ]
Previous thread: [PATCH] drivers/media/video/em28xx/: Fix undefined symbol error with CONFIG_SND=N by S.Çağlar on Saturday, February 9, 2008 - 8:27 pm. (1 message)

Next thread: kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit by Niki Denev on Saturday, February 9, 2008 - 11:04 pm. (15 messages)