Re: Runaway loop with the current git.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Sunday, December 7, 2008 - 11:31 am

> > The loop is detected and terminated.

Let me introduce you to.. drum roll.. the source code. Its a useful
resource, why don't you use it for once.


        max_modprobes = min(max_threads/2, MAX_KMOD_CONCURRENT);
        atomic_inc(&kmod_concurrent);
        if (atomic_read(&kmod_concurrent) > max_modprobes) {
                /* We may be blaming an innocent here, but unlikely */
                if (kmod_loop_msg++ < 5)
                        printk(KERN_ERR
                               "request_module: runaway loop modprobe
%s\n", module_name);
                atomic_dec(&kmod_concurrent);
                return -ENOMEM;
        }

Happy now. Print it out, share it with friends, find someone who can read
C if you are stuck.


They would still hang. As I repeatedly said for the benefit of two people
who don't seem to be able to read source code, the loop is detected and
terminated. So it already fails the open when it sees it has gotten five
layers deep.


Oh I see. Allow me to explain your position in the words of some small
children I know

	"ME!! ME!! ME!! ME!! ME!!"

I don't care about your obscure corner-case non bug that in fact was a
crypto bug combined with a modprobe bug and where the crypto bug is
now fixed. I do care about not breaking existing users systems. The fact
we do this is why Linux doesn't suck.

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Runaway loop with the current git., Herbert Xu, (Sun Dec 7, 7:49 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 8:14 am)
Re: Runaway loop with the current git., Herbert Xu, (Sun Dec 7, 8:55 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 9:03 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 9:09 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 9:21 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 9:31 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 9:33 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 9:57 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 10:01 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 10:03 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 10:13 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 10:17 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 10:22 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 10:24 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 10:28 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 10:29 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 10:39 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 10:44 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 10:51 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 10:52 am)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Sun Dec 7, 10:54 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 11:03 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 11:13 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 11:15 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 11:21 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 11:22 am)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 11:31 am)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 12:02 pm)
Re: Runaway loop with the current git., Alan Cox, (Sun Dec 7, 1:00 pm)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 3:26 pm)
Re: Runaway loop with the current git., Theodore Tso, (Sun Dec 7, 6:18 pm)
Re: Runaway loop with the current git., Valdis.Kletnieks, (Sun Dec 7, 8:23 pm)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 8:35 pm)
Re: Runaway loop with the current git., Kay Sievers, (Sun Dec 7, 8:56 pm)
Re: Runaway loop with the current git., Evgeniy Polyakov, (Mon Dec 8, 6:06 am)
Re: Runaway loop with the current git., Herbert Xu, (Mon Dec 8, 5:42 pm)
Re: Runaway loop with the current git., Theodore Tso, (Mon Dec 8, 6:09 pm)
Re: Runaway loop with the current git., Kay Sievers, (Mon Dec 8, 7:00 pm)
Re: Runaway loop with the current git., Alan Cox, (Tue Dec 9, 3:13 am)