Stefan Richter wrote:
quoted text > Robert Hancock wrote:
>> If free_irq and
>> request_irq fix anything, then that indicates that the ohci1394 device
>> is generating interrupts at some point during resume,
> ...
>> Likely the driver should be setting some register on the device to
>> disable it from generating interrupts before suspend and it's not doing
>> this.
>
> reg_write(ohci, OHCI1394_IntMaskClear, 0xffffffff);
>
> in ohci1394's .suspend() switches interrupts off.
Presumably it should.. but the fact remains that if free_irq helps
anything, then the device must be generating interrupts for some reason,
and it's really just papering over the problem. Perhaps a quirk of that
particular chip? Something to do with the state it's in after resume?
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [patch] ohci1394: don't leave interrupts enabled durin ... , Robert Hancock , (Sat Dec 6, 8:28 pm)