Re: Regression from 2.6.26: Hibernation (possibly suspend) broken on Toshiba R500 (bisected)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Thursday, December 4, 2008 - 5:03 pm

On Fri, 5 Dec 2008, Rafael J. Wysocki wrote:

Yes, true. In that sense, it minimizes the differences between the 
"working" and "nonworking" case. 

Which is interesting in the sense that it makes it even less likely that 
it's an actual resource clash. 


Well, I suspect that on Frans' machine, there will be no difference at all 
between your patch and my previous patch, since he already had a bridge 
window allocated by the BIOS. And he also had just that firewire and mmc 
thing that only needed that memory window, so he'd end up with the exact 
same resource allocation, methinks.


It all looks very sane. Too bad it apparently doesn't work.


Yes, however, it shouldn't matter.

Except in cae the audio driver (for example) were to access past its MMIO 
window, and we'd have a situation where we care what was just before it or 
after it. That doesn't seem very likely, though.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Regression from 2.6.26: Hibernation (possibly suspend) ..., Rafael J. Wysocki, (Wed Dec 3, 12:40 am)
Re: Regression from 2.6.26: Hibernation (possibly suspend) ..., Rafael J. Wysocki, (Wed Dec 3, 12:52 am)
Re: Regression from 2.6.26: Hibernation (possibly suspend) ..., Linus Torvalds, (Thu Dec 4, 5:03 pm)
MSI changes in .28, Frans Pop, (Fri Dec 5, 1:53 am)
Re: MSI changes in .28, Yinghai Lu, (Fri Dec 5, 2:09 am)
Re: MSI changes in .28, Ingo Molnar, (Fri Dec 5, 5:20 am)
Re: MSI changes in .28, Eric Dumazet, (Fri Dec 5, 6:04 am)
Re: MSI changes in .28, H. Peter Anvin, (Fri Dec 5, 10:49 am)
Re: [PATCH 1/3] PCI: Rework default handling of suspend an ..., Rafael J. Wysocki, (Sat Dec 6, 10:22 am)
Re: [PATCH 2/3] PCI: Suspend and resume PCI Express ports ..., Rafael J. Wysocki, (Sat Dec 6, 10:25 am)
Re: [PATCH 1/3] PCI: Rework default handling of suspend an ..., Rafael J. Wysocki, (Sat Dec 6, 10:43 am)
Re: [PATCH 2/3] PCI: Suspend and resume PCI Express ports ..., Rafael J. Wysocki, (Sat Dec 6, 10:46 am)
Re: [PATCH 2/3] PCI: Suspend and resume PCI Express ports ..., Rafael J. Wysocki, (Sun Dec 7, 5:53 am)
Re: [PATCH 3/3] Sound (HDA Intel): Restore PCI configurati ..., Rafael J. Wysocki, (Thu Dec 11, 1:03 pm)
Re: [PATCH 3/3] Sound (HDA Intel): Restore PCI configurati ..., Rafael J. Wysocki, (Thu Dec 11, 1:38 pm)
Re: Regression from 2.6.26: Hibernation (possibly suspend) ..., Rafael J. Wysocki, (Thu Jan 29, 7:48 am)
Re: Regression from 2.6.26: Hibernation (possibly suspend) ..., Alexey Starikovskiy, (Thu Jan 29, 9:44 am)