[PATCH 8/8] ide-atapi: start dma in a drive-specific way

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Borislav Petkov
Date: Thursday, December 18, 2008 - 12:40 am

There should be no functionality change resulting from this patch.

Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
 drivers/ide/ide-atapi.c |   15 +++++++++++----
 1 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c
index f3dea66..5b92e0a 100644
--- a/drivers/ide/ide-atapi.c
+++ b/drivers/ide/ide-atapi.c
@@ -489,7 +489,7 @@ static int ide_delayed_transfer_pc(ide_drive_t *drive)
 
 static ide_startstop_t ide_transfer_pc(ide_drive_t *drive)
 {
-	struct ide_atapi_pc *pc = drive->pc;
+	struct ide_atapi_pc *uninitialized_var(pc);
 	ide_hwif_t *hwif = drive->hwif;
 	struct request *rq = hwif->hwgroup->rq;
 	ide_expiry_t *expiry;
@@ -519,6 +519,8 @@ static ide_startstop_t ide_transfer_pc(ide_drive_t *drive)
 		expiry  = ide_cd_expiry;
 
 	} else {
+		pc = drive->pc;
+
 		cmd_len = ATAPI_MIN_CDB_BYTES;
 
 		/*
@@ -551,9 +553,14 @@ static ide_startstop_t ide_transfer_pc(ide_drive_t *drive)
 	ide_set_handler(drive, ide_pc_intr, timeout, expiry);
 
 	/* Begin DMA, if necessary */
-	if (pc->flags & PC_FLAG_DMA_OK) {
-		pc->flags |= PC_FLAG_DMA_IN_PROGRESS;
-		hwif->dma_ops->dma_start(drive);
+	if (dev_is_idecd(drive)) {
+		if (drive->dma)
+			hwif->dma_ops->dma_start(drive);
+	} else {
+		if (pc->flags & PC_FLAG_DMA_OK) {
+			pc->flags |= PC_FLAG_DMA_IN_PROGRESS;
+			hwif->dma_ops->dma_start(drive);
+		}
 	}
 
 	/* Send the actual packet */
-- 
1.6.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 2/8] ide-atapi: assign expiry and timeout based on ..., Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 3/8] ide-atapi: split drive-specific functionality ..., Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 5/8] ide-cd: remove handler wrappers, Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 6/8] ide-atapi: remove timeout arg to ide_issue_pc, Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 8/8] ide-atapi: start dma in a drive-specific way, Borislav Petkov, (Thu Dec 18, 12:40 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Bartlomiej Zolnierki ..., (Fri Dec 19, 1:15 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 19, 2:19 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 19, 11:28 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Bartlomiej Zolnierki ..., (Sun Dec 21, 12:05 pm)
Re: [PATCH 2/8] ide-atapi: assign expiry and timeout based ..., Bartlomiej Zolnierki ..., (Sun Dec 21, 12:06 pm)
Re: [PATCH 5/8] ide-cd: remove handler wrappers, Bartlomiej Zolnierki ..., (Sun Dec 21, 12:15 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 26, 6:45 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 26, 6:46 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 26, 6:46 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Bartlomiej Zolnierki ..., (Mon Dec 29, 11:57 am)