[PATCH 3/8] ide-atapi: split drive-specific functionality in ide_issue_pc

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Borislav Petkov
Date: Thursday, December 18, 2008 - 12:40 am

There should be no functionality change resulting from this patch.

Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
 drivers/ide/ide-atapi.c |   36 ++++++++++++++++++++----------------
 1 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c
index 5295b26..2577782 100644
--- a/drivers/ide/ide-atapi.c
+++ b/drivers/ide/ide-atapi.c
@@ -565,39 +565,43 @@ static ide_startstop_t ide_transfer_pc(ide_drive_t *drive)
 
 ide_startstop_t ide_issue_pc(ide_drive_t *drive, unsigned int timeout)
 {
-	struct ide_atapi_pc *pc = drive->pc;
+	struct ide_atapi_pc *pc;
 	ide_hwif_t *hwif = drive->hwif;
 	ide_expiry_t *expiry = NULL;
 	u32 tf_flags;
 	u16 bcount;
 
-	/* We haven't transferred any data yet */
-	pc->xferred = 0;
-	pc->cur_pos = pc->buf;
-
 	if (dev_is_idecd(drive)) {
 		tf_flags = IDE_TFLAG_OUT_NSECT | IDE_TFLAG_OUT_LBAL;
 		bcount = ide_cd_get_xferlen(hwif->hwgroup->rq);
 		expiry = ide_cd_expiry;
+
+		if (drive->dma)
+			drive->dma = !hwif->dma_ops->dma_setup(drive);
 	} else {
+		pc = drive->pc;
+
+		/* We haven't transferred any data yet */
+		pc->xferred = 0;
+		pc->cur_pos = pc->buf;
+
 		tf_flags = IDE_TFLAG_OUT_DEVICE;
 		bcount = ((drive->media == ide_tape) ?
 				pc->req_xfer :
 				min(pc->req_xfer, 63 * 1024));
-	}
 
-	if (pc->flags & PC_FLAG_DMA_ERROR) {
-		pc->flags &= ~PC_FLAG_DMA_ERROR;
-		ide_dma_off(drive);
-	}
+		if (pc->flags & PC_FLAG_DMA_ERROR) {
+			pc->flags &= ~PC_FLAG_DMA_ERROR;
+			ide_dma_off(drive);
+		}
 
-	if (((pc->flags & PC_FLAG_DMA_OK) &&
-		(drive->dev_flags & IDE_DFLAG_USING_DMA)) ||
-	    drive->dma)
-		drive->dma = !hwif->dma_ops->dma_setup(drive);
+		if ((pc->flags & PC_FLAG_DMA_OK) &&
+		     (drive->dev_flags & IDE_DFLAG_USING_DMA))
+			drive->dma = !hwif->dma_ops->dma_setup(drive);
 
-	if (!drive->dma)
-		pc->flags &= ~PC_FLAG_DMA_OK;
+		if (!drive->dma)
+			pc->flags &= ~PC_FLAG_DMA_OK;
+	}
 
 	ide_pktcmd_tf_load(drive, tf_flags, bcount, drive->dma);
 
-- 
1.6.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 2/8] ide-atapi: assign expiry and timeout based on ..., Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 3/8] ide-atapi: split drive-specific functionality ..., Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 5/8] ide-cd: remove handler wrappers, Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 6/8] ide-atapi: remove timeout arg to ide_issue_pc, Borislav Petkov, (Thu Dec 18, 12:40 am)
[PATCH 8/8] ide-atapi: start dma in a drive-specific way, Borislav Petkov, (Thu Dec 18, 12:40 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Bartlomiej Zolnierki ..., (Fri Dec 19, 1:15 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 19, 2:19 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 19, 11:28 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Bartlomiej Zolnierki ..., (Sun Dec 21, 12:05 pm)
Re: [PATCH 2/8] ide-atapi: assign expiry and timeout based ..., Bartlomiej Zolnierki ..., (Sun Dec 21, 12:06 pm)
Re: [PATCH 5/8] ide-cd: remove handler wrappers, Bartlomiej Zolnierki ..., (Sun Dec 21, 12:15 pm)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 26, 6:45 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 26, 6:46 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Borislav Petkov, (Fri Dec 26, 6:46 am)
Re: [PATCH 0/8] ide-cd: first conversion batch, Bartlomiej Zolnierki ..., (Mon Dec 29, 11:57 am)