Re: [PATCH] UBIFS: fix compilation warnings

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Sebastian Andrzej Siewior
Date: Sunday, November 30, 2008 - 11:58 am

* Adrian Hunter | 2008-11-24 12:03:41 [+0200]:

Indeed. BUT:

Is there actually a reason why Alpha is the only arch having
__kernel_ino_t defined as unsigned int instead of unsigned long ?
(except s390 in 32bit mode).

I just checked and I haven't seen anything that would point out that
__kernel_ino_t / ino_t is part of user space API.
What I've found instead is for instance that ext2 relies that ino_t is a
long:

|struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
|{
....
|        raw_inode = ext2_get_inode(inode->i_sb, ino, &bh);

and the prototype is:
|static struct ext2_inode *ext2_get_inode(struct super_block *sb, ino_t ino,
|                                         struct buffer_head **p)

So we lose the upper 32bit on Alpha. Unless the whole system is
self-contained and the ext2_iget() user never passes something > ino_t.

Any comments?

Sebastian
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
UBIFS updates for 2.6.28, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: remove printk, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: endian handling fixes and annotations, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] MAINTAINERS: change UBI/UBIFS git tree URLs, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: fix compilation warnings, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: allow for gaps when dirtying the LPT, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: do not print scary memory allocation warnings, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: do not allocate too much, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
[PATCH] UBIFS: pre-allocate bulk-read buffer, Artem Bityutskiy, (Fri Nov 21, 10:19 am)
Re: [PATCH] UBIFS: fix compilation warnings, Sebastian Andrzej Si ..., (Sat Nov 22, 11:54 am)
Re: [PATCH] UBIFS: endian handling fixes and annotations, Sebastian Andrzej Si ..., (Sat Nov 22, 12:27 pm)
Re: [PATCH] UBIFS: endian handling fixes and annotations, Harvey Harrison, (Sat Nov 22, 8:21 pm)
Re: [PATCH] UBIFS: endian handling fixes and annotations, Sebastian Andrzej Si ..., (Sun Nov 23, 2:28 am)
Re: [PATCH] UBIFS: fix compilation warnings, Adrian Hunter, (Mon Nov 24, 3:03 am)
Re: [PATCH] UBIFS: endian handling fixes and annotations, Adrian Hunter, (Mon Nov 24, 7:19 am)
Re: [PATCH] UBIFS: endian handling fixes and annotations, Harvey Harrison, (Mon Nov 24, 9:46 am)
Re: [PATCH] UBIFS: fix compilation warnings, Sebastian Andrzej Si ..., (Sun Nov 30, 11:58 am)