[PATCH 40/45] NFS: Add read context retention for FS-Cache to call back with [ver #41]

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Howells
Date: Thursday, November 20, 2008 - 7:45 am

Add read context retention so that FS-Cache can call back into NFS when a read
operation on the cache fails EIO rather than reading data.  This permits NFS to
then fetch the data from the server instead using the appropriate security
context.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/nfs/fscache-index.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)


diff --git a/fs/nfs/fscache-index.c b/fs/nfs/fscache-index.c
index a119b56..5b10064 100644
--- a/fs/nfs/fscache-index.c
+++ b/fs/nfs/fscache-index.c
@@ -292,6 +292,30 @@ static void nfs_fscache_inode_now_uncached(void *cookie_netfs_data)
 }
 
 /*
+ * Get an extra reference on a read context.
+ * - This function can be absent if the completion function doesn't require a
+ *   context.
+ * - The read context is passed back to NFS in the event that a data read on the
+ *   cache fails with EIO - in which case the server must be contacted to
+ *   retrieve the data, which requires the read context for security.
+ */
+static void nfs_fh_get_context(void *cookie_netfs_data, void *context)
+{
+	get_nfs_open_context(context);
+}
+
+/*
+ * Release an extra reference on a read context.
+ * - This function can be absent if the completion function doesn't require a
+ *   context.
+ */
+static void nfs_fh_put_context(void *cookie_netfs_data, void *context)
+{
+	if (context)
+		put_nfs_open_context(context);
+}
+
+/*
  * Define the inode object for FS-Cache.  This is used to describe an inode
  * object to fscache_acquire_cookie().  It is keyed by the NFS file handle for
  * an inode.
@@ -308,4 +332,6 @@ const struct fscache_cookie_def nfs_fscache_inode_object_def = {
 	.get_aux	= nfs_fscache_inode_get_aux,
 	.check_aux	= nfs_fscache_inode_check_aux,
 	.now_uncached	= nfs_fscache_inode_now_uncached,
+	.get_context	= nfs_fh_get_context,
+	.put_context	= nfs_fh_put_context,
 };

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/45] Permit filesystem local caching [ver #41], David Howells, (Thu Nov 20, 7:41 am)
[PATCH 12/45] FS-Cache: Root index definition [ver #41], David Howells, (Thu Nov 20, 7:42 am)
[PATCH 13/45] FS-Cache: Add cache tag handling [ver #41], David Howells, (Thu Nov 20, 7:42 am)
[PATCH 14/45] FS-Cache: Add cache management [ver #41], David Howells, (Thu Nov 20, 7:42 am)
[PATCH 16/45] FS-Cache: Add netfs registration [ver #41], David Howells, (Thu Nov 20, 7:43 am)
[PATCH 17/45] FS-Cache: Bit waiting helpers [ver #41], David Howells, (Thu Nov 20, 7:43 am)
[PATCH 28/45] FS-Cache: Make kAFS use FS-Cache [ver #41], David Howells, (Thu Nov 20, 7:44 am)
[PATCH 36/45] NFS: Use local disk inode cache [ver #41], David Howells, (Thu Nov 20, 7:44 am)
[PATCH 39/45] NFS: FS-Cache page management [ver #41], David Howells, (Thu Nov 20, 7:45 am)
[PATCH 40/45] NFS: Add read context retention for FS-Cache ..., David Howells, (Thu Nov 20, 7:45 am)
[PATCH 44/45] NFS: Display local caching state [ver #41], David Howells, (Thu Nov 20, 7:45 am)
Re: [PATCH 24/45] CacheFiles: Add a hook to write a single ..., Valdis.Kletnieks, (Fri Nov 21, 10:15 am)
FS-Cache Benchmarks, David Howells, (Tue Nov 25, 6:39 am)