Re: [RFC,v2] x86_64: save_args out of line

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: H. Peter Anvin
Date: Tuesday, November 18, 2008 - 5:01 pm

Andi Kleen wrote:

We already have a "Linux magic asm dialect" which require CFI knowledge. 
  Nothing can change that other than dumping the requirement that we 
have valid CFI data.  However, the current code is hard to read and easy 
to trip up on.  We can at least make it easier, especially to read -- 
and making it easier to read will help writers, too.

	-hpa
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] trivial, entry_64: remove whitespace at end of lines, Alexander van Heukelum, (Sun Nov 16, 7:29 am)
[RFC] x86: save_args out of line, Alexander van Heukelum, (Sun Nov 16, 7:29 am)
Re: [RFC] x86: save_args out of line, Glauber Costa, (Mon Nov 17, 5:14 am)
Re: [RFC] x86: save_args out of line, Andi Kleen, (Mon Nov 17, 5:53 am)
Re: [RFC] x86: save_args out of line, Alexander van Heukelum, (Mon Nov 17, 8:13 am)
Re: [PATCH] trivial, entry_64: remove whitespace at end of ..., Alexander van Heukelum, (Mon Nov 17, 8:14 am)
Re: [RFC] x86: save_args out of line, Alexander van Heukelum, (Mon Nov 17, 8:37 am)
[RFC,v2] x86_64: save_args out of line, Alexander van Heukelum, (Mon Nov 17, 10:52 am)
Re: [RFC] x86: save_args out of line, Andi Kleen, (Mon Nov 17, 11:23 am)
Re: [RFC] x86: save_args out of line, Cyrill Gorcunov, (Mon Nov 17, 12:22 pm)
Re: [RFC] x86: save_args out of line, Cyrill Gorcunov, (Mon Nov 17, 12:29 pm)
Re: [RFC] x86: save_args out of line, Alexander van Heukelum, (Mon Nov 17, 12:43 pm)
Re: [RFC] x86: save_args out of line, Alexander van Heukelum, (Mon Nov 17, 12:49 pm)
Re: [RFC] x86: save_args out of line, Cyrill Gorcunov, (Mon Nov 17, 12:49 pm)
Re: [RFC] x86: save_args out of line, Cyrill Gorcunov, (Mon Nov 17, 12:54 pm)
Re: [RFC,v2] x86_64: save_args out of line, Jan Beulich, (Tue Nov 18, 1:09 am)
Re: [RFC,v2] x86_64: save_args out of line, Alexander van Heukelum, (Tue Nov 18, 4:16 am)
Re: [RFC,v2] x86_64: save_args out of line, Jan Beulich, (Tue Nov 18, 5:51 am)
Re: [RFC,v2] x86_64: save_args out of line, Ingo Molnar, (Tue Nov 18, 7:03 am)
Re: [RFC,v2] x86_64: save_args out of line, Jan Beulich, (Tue Nov 18, 7:52 am)
Re: [RFC,v2] x86_64: save_args out of line, Ingo Molnar, (Tue Nov 18, 8:00 am)
Re: [RFC,v2] x86_64: save_args out of line, Roland McGrath, (Tue Nov 18, 3:53 pm)
Re: [RFC,v2] x86_64: save_args out of line, Andi Kleen, (Tue Nov 18, 4:35 pm)
Re: [RFC,v2] x86_64: save_args out of line, Jeremy Fitzhardinge, (Tue Nov 18, 4:36 pm)
Re: [RFC,v2] x86_64: save_args out of line, H. Peter Anvin, (Tue Nov 18, 4:44 pm)
Re: [RFC,v2] x86_64: save_args out of line, Roland McGrath, (Tue Nov 18, 4:45 pm)
Re: [RFC,v2] x86_64: save_args out of line, H. Peter Anvin, (Tue Nov 18, 5:01 pm)
Re: [RFC,v2] x86_64: save_args out of line, Andi Kleen, (Tue Nov 18, 5:06 pm)
Re: [RFC,v2] x86_64: save_args out of line, Jeremy Fitzhardinge, (Tue Nov 18, 5:08 pm)
[PATCH/RFC] Move entry_64.S register saving out of the macros, Alexander van Heukelum, (Tue Nov 18, 5:18 pm)
Re: [RFC,v2] x86_64: save_args out of line, Ingo Molnar, (Wed Nov 19, 3:34 am)
Re: [RFC,v2] x86_64: save_args out of line, Ingo Molnar, (Wed Nov 19, 1:09 pm)
[PATCH] x86: clean up after: move entry_64.S register savi ..., Alexander van Heukelum, (Thu Nov 20, 6:40 am)
Re: [PATCH] x86: clean up after: move entry_64.S register ..., Alexander van Heukelum, (Thu Nov 20, 8:26 am)
Re: [PATCH] x86: clean up after: move entry_64.S register ..., Alexander van Heukelum, (Thu Nov 20, 8:57 am)
Re: [PATCH] x86: clean up after: move entry_64.S register ..., Alexander van Heukelum, (Thu Nov 20, 9:29 am)
[PATCH] x86: Introduce save_rest and restructure the PTREG ..., Alexander van Heukelum, (Fri Nov 21, 8:41 am)
[PATCH] x86: entry_64.S: Factor out save_paranoid and para ..., Alexander van Heukelum, (Fri Nov 21, 8:43 am)
[PATCH] Split out some macro's and move common code to par ..., Alexander van Heukelum, (Fri Nov 21, 8:44 am)
[PATCH] x86: include ENTRY/END in entry handlers in entry_64.S, Alexander van Heukelum, (Sun Nov 23, 2:08 am)
[PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE_END, Alexander van Heukelum, (Sun Nov 23, 2:15 am)
Re: [PATCH] x86: include ENTRY/END in entry handlers in en ..., Alexander van Heukelum, (Sun Nov 23, 4:23 am)
Re: [PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE_END, Alexander van Heukelum, (Sun Nov 23, 8:04 am)
Re: [PATCH] x86: include ENTRY/END in entry handlers in en ..., Alexander van Heukelum, (Mon Nov 24, 3:06 am)
Re: [PATCH] x86: KPROBE_ENTRY should be paired wth KPROBE_END, Alexander van Heukelum, (Mon Nov 24, 3:26 am)
[PATCH] x86_64: get rid of the use of KPROBE_ENTRY / KPROB ..., Alexander van Heukelum, (Mon Nov 24, 5:24 am)
[PATCH] i386: get rid of the use of KPROBE_ENTRY / KPROBE_END, Alexander van Heukelum, (Mon Nov 24, 7:38 am)