On Wed, 12 Nov 2008 18:38:53 -0500, Mike Frysinger  wrote:

quoted text
> Rather than having every map/mtd driver doing the same sequence of

> registering partitions and/or devices, implement common parse_mtd().

>

> Signed-off-by: Mike Frysinger

> ---

>  drivers/mtd/mtdcore.c   |   37 +++++++++++++++++++++++++++++++++++++

>  include/linux/mtd/mtd.h |    3 +++

>  2 files changed, 40 insertions(+), 0 deletions(-)

I like this idea.
> +int parse_mtd(struct mtd_info *mtd, const char **probe_types,

quoted text
> +              struct mtd_partition *parts, int nr_parts)

> +{

> +#ifdef CONFIG_MTD_PARTITIONS

> +	const char *default_part_probe_types[] = {

> +		"cmdlinepart",

> +		"RedBoot",

> +		NULL

> +	};

But I'm not sure this default_part_probe_types is appropriate.
How about enclose each parser with #ifdefs?
	const char *default_part_probe_types[] = {

#ifdef CONFIG_MTD_CMDLINE_PARTS

		"cmdlinepart",

#endif

#ifdef CONFIG_MTD_REDBOOT_PARTS

		"RedBoot",

#endif

		NULL

	};
This get rid of "RedBoot partition parsing not available" noise in

boot message when you use default_part_probe_types without

MTD_REDBOOT_PARTS.
---

Atsushi Nemoto

--

unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please read the FAQ at  http://www.tux.org/lkml/