Home » Mailing list archives » linux-kernel » 2008 » November » 13

commit "genirq: record trigger type" and powerpc

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mark Nelson <markn@...>
To: Ingo Molnar <mingo@...>
Cc: Benjamin Herrenschmidt <benh@...>, Thomas Gleixner <tglx@...>, <linux-kernel@...>, David Brownell <dbrownell@...>
Subject: commit "genirq: record trigger type" and powerpc
Date: Thursday, November 13, 2008 - 2:30 am

Hi Ingo,

I noticed that after commit 0c5d1eb77a8be917b638344a22afe1398236482b
(genirq: record trigger type), several of our powerpc platforms now
spew out warnings about "No set_type function for IRQ..." (in
particular our Cell blades). This is because in our generic platform
code we call set_irq_type() with information from the device tree
when we establish the interrupt mappings; but we do this regardless
of whether the PIC can actually set a type (it might irrelevant
because the type is essentially hardcoded or as in the case for Cell
the interrupts are just messages being past around that have no real
concept of type, or we could even be dealing with a virtual PIC as
on the PS3).

So, would it be possible to turn the:

	pr_warning("No set_type function... 

into a pr_debug() in kernel/irq/manage.c so when our users upgrade
to newer kernels they don't get scared by a whole bunch of new
warnings?

Many thanks!

Mark
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
commit "genirq: record trigger type" and powerpc, Mark Nelson, (Thu Nov 13, 2:30 am)
Re: commit "genirq: record trigger type" and powerpc, Ingo Molnar, (Thu Nov 13, 3:43 am)
[PATCH] genirq: __irq_set_trigger: change pr_warning to pr_d..., Mark Nelson, (Thu Nov 13, 6:37 am)
Re: [PATCH] genirq: __irq_set_trigger: change pr_warning to ..., Ingo Molnar, (Thu Nov 13, 7:11 am)