login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
October
»
9
Re: [PATCH 43/76] tty: Redo current tty locking
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [author]
[view in full thread]
From:
Derek Fawcus <dfawcus@...>
To: Alan Cox <alan@...>
Cc: <linux-kernel@...>
Subject:
Re: [PATCH 43/76] tty: Redo current tty locking
Date: Thursday, October 9, 2008 - 9:21 am
On Sun, Oct 05, 2008 at 05:15:37PM +0100, Alan Cox wrote:
quoted text
> diff --git a/include/linux/tty.h b/include/linux/tty.h > index c30ed8d..e00393a 100644 > --- a/include/linux/tty.h > +++ b/include/linux/tty.h > @@ -361,6 +361,7 @@ extern int is_ignored(int sig); > extern int tty_signal(int sig, struct tty_struct *tty); > extern void tty_hangup(struct tty_struct *tty); > extern void tty_vhangup(struct tty_struct *tty); > +extern void tty_vhangup_self(void); > extern void tty_unhangup(struct file *filp); > extern int tty_hung_up_p(struct file *filp); > extern void do_SAK(struct tty_struct *tty);
From a pedantic pov shouldn't the above be part of patch 42 - where you actually created tty_vhangup_self()? DF --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [author]
Messages in current thread:
[PATCH 00/76] Queued TTY Patches
, Alan Cox
, (Sun Oct 5, 12:04 pm)
[PATCH 76/76] ftdi: A few errors are err() that should be de...
, Alan Cox
, (Sun Oct 5, 12:25 pm)
[PATCH 75/76] usb: fix pl2303 initialization
, Alan Cox
, (Sun Oct 5, 12:25 pm)
[PATCH 74/76] tty: tty_io.c shadows sparse fix
, Alan Cox
, (Sun Oct 5, 12:25 pm)
[PATCH 73/76] serial: fix device name reporting when minor s...
, Alan Cox
, (Sun Oct 5, 12:24 pm)
[PATCH 72/76] serial: allow 8250 to be used on sparc
, Alan Cox
, (Sun Oct 5, 12:24 pm)
[PATCH 71/76] serial-make-uart_ports-ioport-unsigned-long-fix
, Alan Cox
, (Sun Oct 5, 12:24 pm)
[PATCH 70/76] applicom: Fix an unchecked user ioctl range an...
, Alan Cox
, (Sun Oct 5, 12:24 pm)
[PATCH 69/76] hso: net driver using tty without locking
, Alan Cox
, (Sun Oct 5, 12:24 pm)
[PATCH 68/76] tty: Minor tidyups and document fixes for n_tty
, Alan Cox
, (Sun Oct 5, 12:23 pm)
[PATCH 67/76] tty: Remove lots of NULL checks
, Alan Cox
, (Sun Oct 5, 12:23 pm)
Re: [PATCH 67/76] tty: Remove lots of NULL checks
, Geert Uytterhoeven
, (Mon Oct 6, 4:58 am)
Re: [PATCH 67/76] tty: Remove lots of NULL checks
, Alan Cox
, (Mon Oct 6, 6:50 am)
[PATCH 66/76] tty: fix up gigaset a bit
, Alan Cox
, (Sun Oct 5, 12:23 pm)
[PATCH 65/76] tty: Fallout from tty-move-canon-specials
, Alan Cox
, (Sun Oct 5, 12:23 pm)
[PATCH 64/76] tty: some ICANON magic is in the wrong places
, Alan Cox
, (Sun Oct 5, 12:22 pm)
[PATCH 63/76] tty: simplify ktermios allocation
, Alan Cox
, (Sun Oct 5, 12:22 pm)
[PATCH 62/76] pty: simplify unix98 allocation
, Alan Cox
, (Sun Oct 5, 12:22 pm)
[PATCH 61/76] pty: Fix allocation failure double free
, Alan Cox
, (Sun Oct 5, 12:22 pm)
[PATCH 60/76] pty: Coding style and polish
, Alan Cox
, (Sun Oct 5, 12:22 pm)
[PATCH 59/76] Simplify devpts_pty_kill
, Alan Cox
, (Sun Oct 5, 12:21 pm)
[PATCH 58/76] Simplify devpts_pty_new()
, Alan Cox
, (Sun Oct 5, 12:21 pm)
[PATCH 57/76] Simplify devpts_get_tty()
, Alan Cox
, (Sun Oct 5, 12:21 pm)
[PATCH 56/76] Add an instance parameter devpts interfaces
, Alan Cox
, (Sun Oct 5, 12:21 pm)
[PATCH 55/76] Move tty lookup/reopen to caller
, Alan Cox
, (Sun Oct 5, 12:21 pm)
[PATCH 54/76] tty: extract the pty init time special cases
, Alan Cox
, (Sun Oct 5, 12:21 pm)
[PATCH 53/76] tty: Finish fixing up the init_dev interface t...
, Alan Cox
, (Sun Oct 5, 12:20 pm)
[PATCH 52/76] tty: More driver operations
, Alan Cox
, (Sun Oct 5, 12:20 pm)
[PATCH 51/76] tty: kref the tty driver object
, Alan Cox
, (Sun Oct 5, 12:20 pm)
[PATCH 50/76] tty: Clean up the tty_init_dev changes further
, Alan Cox
, (Sun Oct 5, 12:19 pm)
[PATCH 49/76] tty: Move parts of tty_init_dev into new funct...
, Alan Cox
, (Sun Oct 5, 12:19 pm)
[PATCH 48/76] tty: Remove more special casing and out of pla...
, Alan Cox
, (Sun Oct 5, 12:18 pm)
[PATCH 47/76] tty: shutdown method
, Alan Cox
, (Sun Oct 5, 12:18 pm)
[PATCH 46/76] vt: remove bogus lock dropping
, Alan Cox
, (Sun Oct 5, 12:18 pm)
[PATCH 45/76] pty: If the administrator creates a device for...
, Alan Cox
, (Sun Oct 5, 12:17 pm)
[PATCH 44/76] tty: Fix abusers of current->sighand->tty
, Alan Cox
, (Sun Oct 5, 12:16 pm)
[PATCH 43/76] tty: Redo current tty locking
, Alan Cox
, (Sun Oct 5, 12:15 pm)
Re: [PATCH 43/76] tty: Redo current tty locking
, Derek Fawcus
, (Thu Oct 9, 9:21 am)
[PATCH 42/76] tty: the vhangup syscall is racy
, Alan Cox
, (Sun Oct 5, 12:15 pm)
[PATCH 41/76] mxser: Switch to kref tty
, Alan Cox
, (Sun Oct 5, 12:14 pm)
[PATCH 40/76] stallion: Use krefs
, Alan Cox
, (Sun Oct 5, 12:13 pm)
[PATCH 39/76] tty: kref usage for isicom and moxa
, Alan Cox
, (Sun Oct 5, 12:12 pm)
[PATCH 38/76] tty: usb-serial krefs
, Alan Cox
, (Sun Oct 5, 12:11 pm)
Re: [PATCH 38/76] tty: usb-serial krefs
, Greg KH
, (Mon Oct 6, 1:36 am)
Re: [PATCH 38/76] tty: usb-serial krefs
, Alan Cox
, (Mon Oct 6, 5:02 am)
Re: [PATCH 38/76] tty: usb-serial krefs
, Greg KH
, (Tue Oct 7, 12:13 am)
[PATCH 37/76] tty: Move tty_write_message out of kernel/printk
, Alan Cox
, (Sun Oct 5, 12:10 pm)
[PATCH 36/76] tty: Make get_current_tty use a kref
, Alan Cox
, (Sun Oct 5, 12:10 pm)
Re: [PATCH 36/76] tty: Make get_current_tty use a kref
, Louis Rilling
, (Mon Oct 6, 6:35 am)
Re: [PATCH 36/76] tty: Make get_current_tty use a kref
, Alan Cox
, (Mon Oct 6, 6:56 am)
[PATCH 35/76] tty: compare the tty winsize
, Alan Cox
, (Sun Oct 5, 12:10 pm)
[PATCH 34/76] tty: Termios locking - sort out real_tty confu...
, Alan Cox
, (Sun Oct 5, 12:10 pm)
[PATCH 33/76] tty: Add termiox
, Alan Cox
, (Sun Oct 5, 12:09 pm)
[PATCH 32/76] tty: ipw need reworking
, Alan Cox
, (Sun Oct 5, 12:09 pm)
[PATCH 31/76] tty: Cris has a nice RS485 ioctl so we should ...
, Alan Cox
, (Sun Oct 5, 12:09 pm)
[PATCH 30/76] 8250: remove a few inlines of dubious value
, Alan Cox
, (Sun Oct 5, 12:08 pm)
[PATCH 29/76] Char: sx, fix io unmapping
, Alan Cox
, (Sun Oct 5, 12:08 pm)
[PATCH 28/76] Char: cyclades. remove bogus iomap
, Alan Cox
, (Sun Oct 5, 12:08 pm)
[PATCH 27/76] tty: use krefs to protect driver module counts
, Alan Cox
, (Sun Oct 5, 12:08 pm)
[PATCH 26/76] tty: Add a kref count
, Alan Cox
, (Sun Oct 5, 12:08 pm)
Re: [PATCH 26/76] tty: Add a kref count
, Louis Rilling
, (Mon Oct 6, 6:20 am)
Re: [PATCH 26/76] tty: Add a kref count
, Alan Cox
, (Mon Oct 6, 6:52 am)
[PATCH 25/76] pps: Reserve a line discipline number for PPS
, Alan Cox
, (Sun Oct 5, 12:08 pm)
[PATCH 24/76] tty: Split tty_port into its own file
, Alan Cox
, (Sun Oct 5, 12:07 pm)
[PATCH 23/76] tty: split the buffering from tty_io
, Alan Cox
, (Sun Oct 5, 12:07 pm)
[PATCH 22/76] serial: Make uart_port's ioport "unsigned long".
, Alan Cox
, (Sun Oct 5, 12:07 pm)
Re: [PATCH 22/76] serial: Make uart_port's ioport "unsigned ...
, Josh Boyer
, (Mon Oct 6, 8:53 am)
[PATCH 21/76] audit: Handle embedded NUL in TTY input auditing
, Alan Cox
, (Sun Oct 5, 12:07 pm)
[PATCH 20/76] ip2: avoid add_timer with pending timer
, Alan Cox
, (Sun Oct 5, 12:07 pm)
[PATCH 19/76] ip2, init/deinit cleanup
, Alan Cox
, (Sun Oct 5, 12:07 pm)
[PATCH 18/76] ip2, fix sparse warnings
, Alan Cox
, (Sun Oct 5, 12:07 pm)
[PATCH 17/76] ip2, cleanup globals
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 16/76] Char: merge ip2main and ip2base
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 15/76] uml: small cleanups and note bugs to be dealt ...
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 14/76] tty: move tioclinux from a special case
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 13/76] Blackfin Serial Driver: Fix bug - request UART...
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 12/76] Blackfin Serial Driver: Fix bug - ircp fails o...
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 10/76] Blackfin Serial Driver: Remove useless stop
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 11/76] Blackfin Serial Driver: Fix bug - Don't call t...
, Alan Cox
, (Sun Oct 5, 12:06 pm)
[PATCH 09/76] Blackfin Serial Driver: move common variables ...
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 08/76] Blackfin Serial Driver: trim trailing whitespa...
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 07/76] Blackfin Serial Driver: Fix bug - should suspe...
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 06/76] Blackfin Serial Driver: use __initdata for dat...
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 05/76] 8250: Remove NR_IRQ usage
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 04/76] epca: call tty_port_init
, Alan Cox
, (Sun Oct 5, 12:05 pm)
[PATCH 03/76] coldfire: scheduled SERIAL_COLDFIRE removal
, Alan Cox
, (Sun Oct 5, 12:04 pm)
[PATCH 02/76] drivers/char/hvc_console.c: adjust call to put...
, Alan Cox
, (Sun Oct 5, 12:04 pm)
[PATCH 01/76] drivers/serial/crisv10.c: add missing put_tty_...
, Alan Cox
, (Sun Oct 5, 12:04 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Andrew Morton
2.6.25-mm1
david
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
git
:
linux-netdev
:
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
David Miller
[GIT]: Networking
Natalie Protasevich
[BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
5 users
and
495 guests
online.
Online users
Jeremy
strcmp
madelbalsha82
peterrock23
madelbalsha82
Syndicate