Andi Kleen wrote:
quoted text >> In this case, why not define it as:
>> static char buf[20*NR_CPUS + 100];
>
> Actually you should near never use NR_CPUS now but always num_possible_cpus()
> (or even num_online_cpus()) Using NR_CPUS can lead to extreme waste
> of memory on kernels which are compiled for 4096 CPUs for example.
>
> And with num_possible_cpus() kmalloc is needed.
>
> -Andi
>
>
>
I thought the default value of NR_CPUS is 32.
if NR_CPUS is too large, I think using seq_file is good idea,
and rcuclassic_trace_mutex is not need too.
Lai
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH] rudimentary tracing for Classic RCU , Lai Jiangshan , (Thu Oct 9, 12:05 am)