Re: [PATCH] rudimentary tracing for Classic RCU

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Lai Jiangshan
Date: Wednesday, October 8, 2008 - 11:20 pm

Paul E. McKenney wrote:

I think that we can move it to lib/Kconfig.debug.


add __init:
static int __init rcuclassic_debugfs_init(void)


I'm wondering about this.
rcuclassic_trace_buf is kmalloc-ed when init module.

In this case, why not define it as:
static char buf[20*NR_CPUS + 100];

and use it like:
pos += snprintf(buf + cnt, sizeof(buf) - cnt, ...);




I think this trace file shows too little vars for classic rcu.

It is better that this trace file shows more data.
such as some data in struct rcu_data(quiescent state handling fields, batch, qlen).

or add new files: rcu/rcu_data<cpu#>


Thanks, Lai

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
scheduler hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Mon Oct 6, 7:12 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Mon Oct 6, 4:28 pm)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Paul E. McKenney, (Mon Oct 6, 8:08 pm)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Tue Oct 7, 12:15 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Paul E. McKenney, (Tue Oct 7, 8:26 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Tue Oct 7, 8:49 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Paul E. McKenney, (Tue Oct 7, 9:34 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Tue Oct 7, 2:09 pm)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Paul E. McKenney, (Tue Oct 7, 2:22 pm)
[PATCH] rudimentary tracing for Classic RCU, Paul E. McKenney, (Wed Oct 8, 6:08 pm)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Paul E. McKenney, (Wed Oct 8, 6:33 pm)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Wed Oct 8, 9:56 pm)
Re: [PATCH] rudimentary tracing for Classic RCU, Lai Jiangshan, (Wed Oct 8, 11:20 pm)
Re: [PATCH] rudimentary tracing for Classic RCU, Andi Kleen, (Wed Oct 8, 11:55 pm)
Re: [PATCH] rudimentary tracing for Classic RCU, Lai Jiangshan, (Thu Oct 9, 12:05 am)
Re: [PATCH] rudimentary tracing for Classic RCU, KOSAKI Motohiro, (Thu Oct 9, 12:14 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Thomas Gleixner, (Thu Oct 9, 12:24 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Lai Jiangshan, (Thu Oct 9, 12:26 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Andi Kleen, (Thu Oct 9, 1:06 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Andi Kleen, (Thu Oct 9, 1:22 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Frédéric Weisbecker, (Thu Oct 9, 3:23 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Andi Kleen, (Thu Oct 9, 3:53 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Frédéric Weisbecker, (Thu Oct 9, 4:44 am)
Re: RCU hang on cpu re-hotplug with 2.6.27rc8, Paul E. McKenney, (Thu Oct 9, 4:44 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Paul E. McKenney, (Thu Oct 9, 4:50 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Paul E. McKenney, (Thu Oct 9, 4:50 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Paul E. McKenney, (Thu Oct 9, 4:54 am)
Re: [PATCH] rudimentary tracing for Classic RCU, Frédéric Weisbecker, (Thu Oct 9, 6:01 am)
[PATCH] v2 rudimentary tracing for Classic RCU, Paul E. McKenney, (Thu Oct 9, 8:44 pm)
Re: [PATCH] rudimentary tracing for Classic RCU, Paul E. McKenney, (Fri Oct 10, 4:48 am)
[PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Mon Oct 13, 4:09 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Lai Jiangshan, (Mon Oct 13, 8:53 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Tue Oct 14, 7:35 am)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Lai Jiangshan, (Thu Oct 23, 4:12 am)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Sun Oct 26, 2:59 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Mon Oct 27, 2:50 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Mon Oct 27, 4:57 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Tue Oct 28, 6:16 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Lai Jiangshan, (Tue Oct 28, 6:31 pm)
Re: [PATCH] v3 rudimentary tracing for Classic RCU, Paul E. McKenney, (Thu Oct 30, 8:52 am)