Home » Mailing list archives » linux-kernel » 2008 » October » 9

[PATCH 41/42] ext4: Avoid double dirtying of super block in ext4_put_super()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Theodore Ts'o
Subject: [PATCH 41/42] ext4: Avoid double dirtying of super block in ext4_put_super()
Date: Wednesday, October 8, 2008 - 9:05 pm

From: Andi Kleen <andi@firstfloor.org>

While reading code I noticed that ext4_put_super() dirties the
superblock bh twice. It is always done in ext4_commit_super()
too. Remove the redundant dirty operation.
Should be a nop semantically.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 fs/ext4/super.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9c02146..7d86560 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -512,8 +512,6 @@ static void ext4_put_super(struct super_block *sb)
 	if (!(sb->s_flags & MS_RDONLY)) {
 		EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER);
 		es->s_state = cpu_to_le16(sbi->s_mount_state);
-		BUFFER_TRACE(sbi->s_sbh, "marking dirty");
-		mark_buffer_dirty(sbi->s_sbh);
 		ext4_commit_super(sb, es, 1);
 	}
 	if (sbi->s_proc) {
-- 
1.5.6.1.205.ge2c7.dirty

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 27/42] ext4: move /proc setup and teardown out of m ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 28/42] ext4: Combine proc file handling into a sing ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 29/42] ext4: Use readahead when reading an inode fr ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 30/42] ext4: Remove old legacy block allocator, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 31/42] ext4: fix initialization of UNINIT bitmap blocks, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 32/42] jbd2: abort instead of waiting for nonexiste ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 33/42] ext4: Add debugging markers that can be used ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 34/42] jbd2: Fix buffer head leak when writing the ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 35/42] ext4: fix xattr deadlock, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 36/42] vfs: vfs-level fiemap interface, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 37/42] ocfs2: fiemap support, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 38/42] generic block based fiemap implementation, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 39/42] Hook ext4 to the vfs fiemap interface., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 40/42] Update ext4 MAINTAINERS file, Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 41/42] ext4: Avoid double dirtying of super block i ..., Theodore Ts'o, (Wed Oct 8, 9:05 pm)
[PATCH 42/42] ext4: Rename ext4dev to ext4, Theodore Ts'o, (Wed Oct 8, 9:06 pm)
Re: [PATCH 29/42] ext4: Use readahead when reading an inod ..., Aneesh Kumar K.V, (Thu Oct 9, 1:18 am)
Re: [PATCH 42/42] ext4: Rename ext4dev to ext4, Jeremy Fitzhardinge, (Sat Oct 11, 3:04 pm)
Re: [PATCH 42/42] ext4: Rename ext4dev to ext4, Eric Sandeen, (Sat Oct 11, 3:09 pm)
Re: [PATCH 42/42] ext4: Rename ext4dev to ext4, Jeremy Fitzhardinge, (Sat Oct 11, 3:54 pm)
Re: [PATCH 42/42] ext4: Rename ext4dev to ext4, Theodore Tso, (Sat Oct 11, 3:58 pm)
Re: [PATCH 42/42] ext4: Rename ext4dev to ext4, Grant Coady, (Sat Oct 11, 4:08 pm)
Re: [PATCH 42/42] ext4: Rename ext4dev to ext4, Eric Sandeen, (Sat Oct 11, 6:06 pm)