Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support. | KernelTrap

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support.

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Christoph Hellwig <hch@...>

To: Eric W. Biederman <ebiederm@...>

Cc: Greg KH <gregkh@...>, Mark Ryden <markryde@...>, Benjamin Thery <benjamin.thery@...>, David Shwatrz <dshwatrz@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>, Tejun Heo <htejun@...>, Daniel Lezcano <dlezcano@...>, <linux-kernel@...>, Al Viro <viro@...>, Linux Containers <containers@...>, <netdev@...>

Subject: Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support.

Date: Wednesday, October 8, 2008 - 9:00 am

On Tue, Oct 07, 2008 at 03:27:12PM -0700, Eric W. Biederman wrote:
quoted text> Al reviewed sysfs with my patchset on top of it.
> 
> Al's review found problems in  sysfs with my patchset on top of it.
> 
> If you look at what Al found the majority of those problems exist in sysfs
> without my patches.

And when something is crap your fix it firdt before piling up more shit
on top of it.  And sysfs is a really severe case of that, and you're
piling a _lot_ of shit ontop.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 06/11] sysfs: Implement sysfs tagged directory support., Benjamin Thery, (Wed Jun 18, 1:08 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Sun Jun 22, 10:05 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Thu Jun 26, 4:21 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Sat Jun 28, 11:51 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Mon Jun 30, 2:56 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Tue Jul 1, 2:47 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Tue Jul 1, 5:20 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Tue Jul 1, 6:30 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Tue Jul 1, 8:30 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Tue Jul 1, 11:24 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Tue Jul 1, 11:53 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Wed Jul 2, 12:37 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Wed Jul 2, 12:49 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Wed Jul 2, 11:18 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Thu Jul 3, 1:11 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Daniel Lezcano, (Thu Jul 3, 6:56 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Thu Jul 3, 8:27 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Tejun Heo, (Thu Jul 3, 11:58 am)

[PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Thu Jul 3, 8:48 pm)

Re: [PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Sun Jul 6, 12:42 am)

Re: [PATCH 00/15] sysfs support for namespaces, Cornelia Huck, (Mon Jul 7, 7:41 am)

Re: [PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Mon Jul 7, 8:22 am)

Re: [PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Thu Jul 3, 9:27 pm)

[PATCH 01/15] kobject: Cleanup kobject_rename and !CONFIG_SY..., Eric W. Biederman, (Thu Jul 3, 9:05 pm)

Re: [PATCH 01/15] kobject: Cleanup kobject_rename and !CONFI..., Tejun Heo, (Fri Jul 4, 2:33 am)

[PATCH 02/15] sysfs: Support for preventing unmounts., Eric W. Biederman, (Thu Jul 3, 9:07 pm)

[PATCH 03/15] sysfs: sysfs_get_dentry add a sb parameter, Eric W. Biederman, (Thu Jul 3, 9:08 pm)

[PATCH 04/15] sysfs: Implement __sysfs_get_dentry, Eric W. Biederman, (Thu Jul 3, 9:09 pm)

[PATCH 05/15] sysfs: Rename Support multiple superblocks, Eric W. Biederman, (Thu Jul 3, 9:10 pm)

[PATCH 06/15] Introduce sysfs_sd_setattr and fix sysfs_chmod, Eric W. Biederman, (Thu Jul 3, 9:11 pm)

Re: [PATCH 06/15] Introduce sysfs_sd_setattr and fix sysfs_c..., Tejun Heo, (Fri Jul 4, 2:40 am)

[PATCH 07/15] sysfs: sysfs_chmod_file handle multiple superb..., Eric W. Biederman, (Thu Jul 3, 9:13 pm)

Re: [PATCH 07/15] sysfs: sysfs_chmod_file handle multiple su..., Tejun Heo, (Fri Jul 4, 2:44 am)

[PATCH 08/15] sysfs: Make sysfs_mount static once again., Eric W. Biederman, (Thu Jul 3, 9:14 pm)

Re: [PATCH 08/15] sysfs: Make sysfs_mount static once again., Tejun Heo, (Fri Jul 4, 2:44 am)

[PATCH 09/15] sysfs: Implement sysfs tagged directory support., Eric W. Biederman, (Thu Jul 3, 9:16 pm)

Re: [PATCH 09/15] sysfs: Implement sysfs tagged directory su..., Greg KH, (Tue Aug 19, 10:17 pm)

[PATCH 0/8] sysfs namespace support, Eric W. Biederman, (Thu Aug 21, 2:31 am)

[PATCH 1/8] sysfs: Implement sysfs tagged directory support., Eric W. Biederman, (Thu Aug 21, 2:33 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Benjamin Thery, (Wed Aug 27, 11:18 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Mark Ryden, (Tue Sep 2, 9:54 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Benjamin Thery, (Tue Sep 2, 10:03 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Greg KH, (Tue Sep 2, 1:01 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., David Shwatrz, (Thu Sep 4, 1:33 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Benjamin Thery, (Thu Sep 4, 2:44 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Mark Ryden, (Tue Oct 7, 12:39 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Daniel Lezcano, (Tue Oct 7, 12:52 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Greg KH, (Tue Oct 7, 12:48 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Eric W. Biederman, (Tue Oct 7, 4:31 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Greg KH, (Tue Oct 7, 5:09 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Eric W. Biederman, (Tue Oct 7, 6:27 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Christoph Hellwig, (Wed Oct 8, 9:00 am)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Eric W. Biederman, (Mon Oct 13, 11:20 pm)

Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory supp..., Mark Ryden, (Mon Sep 8, 2:39 pm)

[PATCH 2/8] sysfs: Merge sysfs_rename_dir and sysfs_move_dir, Eric W. Biederman, (Thu Aug 21, 2:34 am)

[PATCH 3/8] sysfs: Implement sysfs_delete_link and sysfs_ren..., Eric W. Biederman, (Thu Aug 21, 2:35 am)

[PATCH 4/8] driver core: Implement tagged directory support ..., Eric W. Biederman, (Thu Aug 21, 2:37 am)

[PATCH 5/8] sysfs: Remove sysfs_create_link_nowarn, Eric W. Biederman, (Thu Aug 21, 2:36 am)

[PATCH 6/8] Revert "netns: Fix device renaming for sysfs", Eric W. Biederman, (Thu Aug 21, 2:38 am)

Re: [PATCH 6/8] Revert "netns: Fix device renaming for sysfs", David Miller, (Thu Aug 21, 2:47 am)

[PATCH 7/8] netns: Enable tagging for net_class directories ..., Eric W. Biederman, (Thu Aug 21, 2:39 am)

Re: [PATCH 7/8] netns: Enable tagging for net_class director..., David Miller, (Thu Aug 21, 2:47 am)

[PATCH 8/8] sysfs: user namespaces: fix bug with clone(CLONE..., Eric W. Biederman, (Thu Aug 21, 2:40 am)

Re: [PATCH 0/8] sysfs namespace support, David Miller, (Thu Aug 21, 2:37 am)

Re: [PATCH 09/15] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Wed Aug 20, 2:58 am)

[PATCH 10/15] sysfs: Merge sysfs_rename_dir and sysfs_move_dir, Eric W. Biederman, (Thu Jul 3, 9:17 pm)

[PATCH 11/15] sysfs: Implement sysfs_delete_link and sysfs_r..., Eric W. Biederman, (Thu Jul 3, 9:18 pm)

[PATCH 12/15] driver core: Implement tagged directory suppor..., Eric W. Biederman, (Thu Jul 3, 9:20 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Fri Jul 4, 3:50 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Fri Jul 4, 9:31 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Fri Jul 4, 9:57 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Fri Jul 4, 6:00 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Greg KH, (Fri Jul 4, 12:12 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Sun Jul 13, 9:54 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Tue Jul 15, 11:25 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Greg KH, (Thu Jul 17, 7:08 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Fri Jul 18, 8:41 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Greg KH, (Fri Jul 18, 2:49 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Sun Aug 3, 2:59 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Jiri Slaby, (Thu Sep 11, 8:45 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Benjamin Thery, (Thu Sep 11, 9:05 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Jiri Slaby, (Fri Sep 12, 2:32 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Fri Jul 18, 9:07 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Fri Jul 18, 4:19 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Wed Jul 16, 1:41 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Wed Jul 16, 1:50 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Wed Jul 16, 2:32 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Wed Jul 16, 2:48 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Wed Jul 16, 5:09 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Tejun Heo, (Wed Jul 16, 3:02 am)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Wed Jul 16, 3:07 pm)

Re: [PATCH 12/15] driver core: Implement tagged directory su..., Eric W. Biederman, (Fri Jul 4, 5:49 pm)

[PATCH 13/15] Revert "netns: Fix device renaming for sysfs", Eric W. Biederman, (Thu Jul 3, 9:21 pm)

[PATCH 14/15] netns: Enable tagging for net_class directorie..., Eric W. Biederman, (Thu Jul 3, 9:22 pm)

[PATCH 15/15] sysfs: user namespaces: fix bug with clone(CLO..., Eric W. Biederman, (Thu Jul 3, 9:23 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Thu Jul 3, 4:08 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Daniel Lezcano, (Thu Jul 3, 2:29 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Daniel Lezcano, (Thu Jul 3, 8:55 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Benjamin Thery, (Thu Jul 3, 8:37 am)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Thu Jul 3, 3:57 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Greg KH, (Wed Jul 2, 8:15 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Serge E. Hallyn, (Mon Jun 30, 5:44 pm)

Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory su..., Eric W. Biederman, (Tue Jul 1, 3:50 am)

Navigation

Popular discussions


linux-kernel:
Christoph Lameter	Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Pekka Enberg	Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/slab.c:2103!"
Glauber de Oliveira Costa	[PATCH 08/79] [PATCH] use identify_boot_cpu
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Natalie Protasevich	[BUG] New Kernel Bugs
David Miller	[GIT]: Networking

Colocation donated by:

Who's online

There are currently 8 users and 1180 guests online.

Online users

Syndicate