[PATCH] documentation: clarify dirty_ratio and dirty_background_ratio description

Previous thread: sending TCP/IP packet based on NIC MTU size by Parav Pandit on Wednesday, October 8, 2008 - 3:41 am. (1 message)

Next thread: PATCH - New S1D1... Epson frambuffer maintainer by Kristoffer Ericson on Wednesday, October 8, 2008 - 4:08 am. (1 message)
From: Andrea Righi
Date: Wednesday, October 8, 2008 - 3:52 am

The current documentation of dirty_ratio and dirty_background_ratio is a
bit misleading.

In the documentation we say that they are "a percentage of total system
memory", but the current page writeback policy, intead, is to apply the
percentages to the dirtyable memory, that means free pages + reclaimable
pages.

Better to be more explicit to clarify this concept.

Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
---
 Documentation/filesystems/proc.txt |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
index f566ad9..be69c8b 100644
--- a/Documentation/filesystems/proc.txt
+++ b/Documentation/filesystems/proc.txt
@@ -1380,15 +1380,16 @@ causes the kernel to prefer to reclaim dentries and inodes.
 dirty_background_ratio
 ----------------------
 
-Contains, as a percentage of total system memory, the number of pages at which
-the pdflush background writeback daemon will start writing out dirty data.
+Contains, as a percentage of the dirtyable system memory (free pages +
+reclaimable pages), the number of pages at which the pdflush background
+writeback daemon will start writing out dirty data.
 
 dirty_ratio
 -----------------
 
-Contains, as a percentage of total system memory, the number of pages at which
-a process which is generating disk writes will itself start writing out dirty
-data.
+Contains, as a percentage of the dirtyable system memory (free pages +
+reclaimable pages), the number of pages at which a process which is generating
+disk writes will itself start writing out dirty data.
 
 dirty_writeback_centisecs
 -------------------------
--

From: KOSAKI Motohiro
Date: Wednesday, October 8, 2008 - 5:42 pm

From: KAMEZAWA Hiroyuki
Date: Wednesday, October 8, 2008 - 6:51 pm

On Wed, 08 Oct 2008 12:52:28 +0200

But I wonder "reclaimable memory" seems to be a difficult word for users....

"free pages + mapped pages + file cache, not including locked page and HugePage"
?
Anyway,

--

From: Andrea Righi
Date: Thursday, October 9, 2008 - 12:32 am

Sounds better. I'll add these details and post a new patch.

Thanks,
--

From: Andrea Righi
Date: Thursday, October 9, 2008 - 12:36 am

The current documentation of dirty_ratio and dirty_background_ratio is a
bit misleading.

In the documentation we say that they are "a percentage of total system
memory", but the current page writeback policy, intead, is to apply the
percentages to the dirtyable memory, that means free pages + reclaimable
pages.

Better to be more explicit to clarify this concept.

Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
 Documentation/filesystems/proc.txt |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
index 394eb2c..474bf8b 100644
--- a/Documentation/filesystems/proc.txt
+++ b/Documentation/filesystems/proc.txt
@@ -1380,15 +1380,18 @@ causes the kernel to prefer to reclaim dentries and inodes.
 dirty_background_ratio
 ----------------------
 
-Contains, as a percentage of total system memory, the number of pages at which
-the pdflush background writeback daemon will start writing out dirty data.
+Contains, as a percentage of the dirtyable system memory (free pages + mapped
+pages + file cache, not including locked pages and HugePages), the number of
+pages at which the pdflush background writeback daemon will start writing out
+dirty data.
 
 dirty_ratio
 -----------------
 
-Contains, as a percentage of total system memory, the number of pages at which
-a process which is generating disk writes will itself start writing out dirty
-data.
+Contains, as a percentage of the dirtyable system memory (free pages + mapped
+pages + file cache, not including locked pages and HugePages), the number of
+pages at which a process which is generating disk writes will itself start
+writing out dirty data.
 
 dirty_writeback_centisecs
 -------------------------
--

Previous thread: sending TCP/IP packet based on NIC MTU size by Parav Pandit on Wednesday, October 8, 2008 - 3:41 am. (1 message)

Next thread: PATCH - New S1D1... Epson frambuffer maintainer by Kristoffer Ericson on Wednesday, October 8, 2008 - 4:08 am. (1 message)