Re: [PATCH] x86 ACPI: Blacklist two HP machines with buggy BIOSes (Re: 2.6.27-rc8+ - first impressions)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Linus Torvalds <torvalds@...>, Rafael J. Wysocki <rjw@...>, Dmitry Torokhov <dmitry.torokhov@...>, <linux-kernel@...>, Andrew Morton <akpm@...>, Len Brown <lenb@...>, Jason Vas Dias <jason.vas.dias@...>
Date: Monday, October 6, 2008 - 1:51 pm

On Mon, 6 Oct 2008, Ingo Molnar wrote:


 None of the above.  This:

691874f: x86: I/O APIC: timer through 8259A second-chance

This change has fixed a problem with the timer for a lot of systems and 
permitted the removal of a bunch of horrible hacks we used to have in our 
I/O-APIC/timer code, including a command-line override parameter, needed 
so that some systems would boot at all.

 This single instance of a piece of some HP gear being twisted beyond 
belief is IMO a minor annoyance and price to pay compared to the gain.  
Please note that apart from the DSDT being buggy on this machine, it has 
an incorrect IRQ 0 override in the ACPI table pointing to the pin #2 of 
the I/O APIC, which is in fact routed to the output of the master 8259A.  
Additionally the pin #0 of the I/O APIC which is indeed routed to the 
output of the 8254 does not receive any interrupts, presumably because of 
some misconfiguration during BIOS initialisation.  So in fact this machine 
suffers from three configuration problems at once of which all add up to 
the end result we can observe.


 It is not just theory.  I did actually analyse the AML code coming from 
the broken DSDT and found the responsible snippets.  See: 
http://lkml.org/lkml/2008/6/20/442 for a reference.  No SMI is involved 
here -- this is native ACPI operation -- Linux calls these snippets 
explicitly as required by the ACPI spec for various actions.


 It will break many if not most of the systems out there which have the 
PIT (rather than the master 8259A) wired to the pin #2 of the I/O APIC 
and correctly reported as such with an ACPI IRQ override.

  Maciej
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Sun Oct 5, 2:36 pm)
Re: 2.6.27-rc8+ - first impressions, Arjan van de Ven, (Sun Oct 5, 3:10 pm)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Mon Oct 6, 2:28 am)
Re: 2.6.27-rc8+ - first impressions, Andreas Herrmann, (Mon Oct 6, 3:53 pm)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Mon Oct 6, 11:42 pm)
Re: 2.6.27-rc8+ - first impressions, Andreas Herrmann, (Tue Oct 7, 5:10 am)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Tue Oct 7, 7:37 am)
Re: 2.6.27-rc8+ - first impressions, Andreas Herrmann, (Tue Oct 7, 9:19 am)
Re: 2.6.27-rc8+ - first impressions, Parag Warudkar, (Tue Oct 7, 8:07 am)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Tue Oct 7, 9:07 pm)
Re: 2.6.27-rc8+ - first impressions, Rafael J. Wysocki, (Sun Oct 5, 2:59 pm)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Sun Oct 5, 3:06 pm)
Re: 2.6.27-rc8+ - first impressions, Rafael J. Wysocki, (Sun Oct 5, 3:19 pm)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Sun Oct 5, 5:18 pm)
Re: 2.6.27-rc8+ - first impressions, Rafael J. Wysocki, (Sun Oct 5, 6:29 pm)
Re: 2.6.27-rc8+ - first impressions, Dmitry Torokhov, (Mon Oct 6, 2:23 am)
Re: [PATCH] x86 ACPI: Blacklist two HP machines with buggy B..., Maciej W. Rozycki, (Mon Oct 6, 1:51 pm)
Re: [PATCH] x86: SB450: skip IRQ0 override if it is not rout..., Maciej W. Rozycki, (Tue Oct 7, 11:25 am)
Re: 2.6.27-rc8+ - first impressions, Parag Warudkar, (Sun Oct 5, 5:40 pm)
Re: 2.6.27-rc8+ - first impressions, Thomas Gleixner, (Sun Oct 5, 3:27 pm)