login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
October
»
6
Re: [PATCH 36/76] tty: Make get_current_tty use a kref
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Alan Cox
Subject:
Re: [PATCH 36/76] tty: Make get_current_tty use a kref
Date: Monday, October 6, 2008 - 3:56 am
On Mon, Oct 06, 2008 at 12:35:40PM +0200, Louis Rilling wrote:
quoted text
> > tty = get_current_tty(); > > if (!tty || tty->driver->major != IBM_TTY3270_MAJOR) { > > - mutex_unlock(&tty_mutex); > > + tty_kref_put(tty); > > Should'nt mutex_unlock() be kept?
Yes.. although it gets fixed later but I will fix that as it will keep the code bisectable. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 00/76] Queued TTY Patches
, Alan Cox
, (Sun Oct 5, 9:04 am)
[PATCH 01/76] drivers/serial/crisv10.c: add missing put_tt ...
, Alan Cox
, (Sun Oct 5, 9:04 am)
[PATCH 02/76] drivers/char/hvc_console.c: adjust call to p ...
, Alan Cox
, (Sun Oct 5, 9:04 am)
[PATCH 03/76] coldfire: scheduled SERIAL_COLDFIRE removal
, Alan Cox
, (Sun Oct 5, 9:04 am)
[PATCH 04/76] epca: call tty_port_init
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 05/76] 8250: Remove NR_IRQ usage
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 06/76] Blackfin Serial Driver: use __initdata for d ...
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 07/76] Blackfin Serial Driver: Fix bug - should sus ...
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 08/76] Blackfin Serial Driver: trim trailing whites ...
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 09/76] Blackfin Serial Driver: move common variable ...
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 10/76] Blackfin Serial Driver: Remove useless stop
, Alan Cox
, (Sun Oct 5, 9:05 am)
[PATCH 11/76] Blackfin Serial Driver: Fix bug - Don't call ...
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 12/76] Blackfin Serial Driver: Fix bug - ircp fails ...
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 13/76] Blackfin Serial Driver: Fix bug - request UA ...
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 14/76] tty: move tioclinux from a special case
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 15/76] uml: small cleanups and note bugs to be deal ...
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 16/76] Char: merge ip2main and ip2base
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 17/76] ip2, cleanup globals
, Alan Cox
, (Sun Oct 5, 9:06 am)
[PATCH 18/76] ip2, fix sparse warnings
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 19/76] ip2, init/deinit cleanup
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 20/76] ip2: avoid add_timer with pending timer
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 21/76] audit: Handle embedded NUL in TTY input auditing
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 22/76] serial: Make uart_port's ioport "unsigned long".
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 23/76] tty: split the buffering from tty_io
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 24/76] tty: Split tty_port into its own file
, Alan Cox
, (Sun Oct 5, 9:07 am)
[PATCH 25/76] pps: Reserve a line discipline number for PPS
, Alan Cox
, (Sun Oct 5, 9:08 am)
[PATCH 26/76] tty: Add a kref count
, Alan Cox
, (Sun Oct 5, 9:08 am)
[PATCH 27/76] tty: use krefs to protect driver module counts
, Alan Cox
, (Sun Oct 5, 9:08 am)
[PATCH 28/76] Char: cyclades. remove bogus iomap
, Alan Cox
, (Sun Oct 5, 9:08 am)
[PATCH 29/76] Char: sx, fix io unmapping
, Alan Cox
, (Sun Oct 5, 9:08 am)
[PATCH 30/76] 8250: remove a few inlines of dubious value
, Alan Cox
, (Sun Oct 5, 9:08 am)
[PATCH 31/76] tty: Cris has a nice RS485 ioctl so we shoul ...
, Alan Cox
, (Sun Oct 5, 9:09 am)
[PATCH 32/76] tty: ipw need reworking
, Alan Cox
, (Sun Oct 5, 9:09 am)
[PATCH 33/76] tty: Add termiox
, Alan Cox
, (Sun Oct 5, 9:09 am)
[PATCH 34/76] tty: Termios locking - sort out real_tty con ...
, Alan Cox
, (Sun Oct 5, 9:10 am)
[PATCH 35/76] tty: compare the tty winsize
, Alan Cox
, (Sun Oct 5, 9:10 am)
[PATCH 36/76] tty: Make get_current_tty use a kref
, Alan Cox
, (Sun Oct 5, 9:10 am)
[PATCH 37/76] tty: Move tty_write_message out of kernel/printk
, Alan Cox
, (Sun Oct 5, 9:10 am)
[PATCH 38/76] tty: usb-serial krefs
, Alan Cox
, (Sun Oct 5, 9:11 am)
[PATCH 39/76] tty: kref usage for isicom and moxa
, Alan Cox
, (Sun Oct 5, 9:12 am)
[PATCH 40/76] stallion: Use krefs
, Alan Cox
, (Sun Oct 5, 9:13 am)
[PATCH 41/76] mxser: Switch to kref tty
, Alan Cox
, (Sun Oct 5, 9:14 am)
[PATCH 42/76] tty: the vhangup syscall is racy
, Alan Cox
, (Sun Oct 5, 9:15 am)
[PATCH 43/76] tty: Redo current tty locking
, Alan Cox
, (Sun Oct 5, 9:15 am)
[PATCH 44/76] tty: Fix abusers of current->sighand->tty
, Alan Cox
, (Sun Oct 5, 9:16 am)
[PATCH 45/76] pty: If the administrator creates a device f ...
, Alan Cox
, (Sun Oct 5, 9:17 am)
[PATCH 46/76] vt: remove bogus lock dropping
, Alan Cox
, (Sun Oct 5, 9:18 am)
[PATCH 47/76] tty: shutdown method
, Alan Cox
, (Sun Oct 5, 9:18 am)
[PATCH 48/76] tty: Remove more special casing and out of p ...
, Alan Cox
, (Sun Oct 5, 9:18 am)
[PATCH 49/76] tty: Move parts of tty_init_dev into new fun ...
, Alan Cox
, (Sun Oct 5, 9:19 am)
[PATCH 50/76] tty: Clean up the tty_init_dev changes further
, Alan Cox
, (Sun Oct 5, 9:19 am)
[PATCH 51/76] tty: kref the tty driver object
, Alan Cox
, (Sun Oct 5, 9:20 am)
[PATCH 52/76] tty: More driver operations
, Alan Cox
, (Sun Oct 5, 9:20 am)
[PATCH 53/76] tty: Finish fixing up the init_dev interface ...
, Alan Cox
, (Sun Oct 5, 9:20 am)
[PATCH 54/76] tty: extract the pty init time special cases
, Alan Cox
, (Sun Oct 5, 9:21 am)
[PATCH 55/76] Move tty lookup/reopen to caller
, Alan Cox
, (Sun Oct 5, 9:21 am)
[PATCH 56/76] Add an instance parameter devpts interfaces
, Alan Cox
, (Sun Oct 5, 9:21 am)
[PATCH 57/76] Simplify devpts_get_tty()
, Alan Cox
, (Sun Oct 5, 9:21 am)
[PATCH 58/76] Simplify devpts_pty_new()
, Alan Cox
, (Sun Oct 5, 9:21 am)
[PATCH 59/76] Simplify devpts_pty_kill
, Alan Cox
, (Sun Oct 5, 9:21 am)
[PATCH 60/76] pty: Coding style and polish
, Alan Cox
, (Sun Oct 5, 9:22 am)
[PATCH 61/76] pty: Fix allocation failure double free
, Alan Cox
, (Sun Oct 5, 9:22 am)
[PATCH 62/76] pty: simplify unix98 allocation
, Alan Cox
, (Sun Oct 5, 9:22 am)
[PATCH 63/76] tty: simplify ktermios allocation
, Alan Cox
, (Sun Oct 5, 9:22 am)
[PATCH 64/76] tty: some ICANON magic is in the wrong places
, Alan Cox
, (Sun Oct 5, 9:22 am)
[PATCH 65/76] tty: Fallout from tty-move-canon-specials
, Alan Cox
, (Sun Oct 5, 9:23 am)
[PATCH 66/76] tty: fix up gigaset a bit
, Alan Cox
, (Sun Oct 5, 9:23 am)
[PATCH 67/76] tty: Remove lots of NULL checks
, Alan Cox
, (Sun Oct 5, 9:23 am)
[PATCH 68/76] tty: Minor tidyups and document fixes for n_tty
, Alan Cox
, (Sun Oct 5, 9:23 am)
[PATCH 69/76] hso: net driver using tty without locking
, Alan Cox
, (Sun Oct 5, 9:24 am)
[PATCH 70/76] applicom: Fix an unchecked user ioctl range ...
, Alan Cox
, (Sun Oct 5, 9:24 am)
[PATCH 71/76] serial-make-uart_ports-ioport-unsigned-long-fix
, Alan Cox
, (Sun Oct 5, 9:24 am)
[PATCH 72/76] serial: allow 8250 to be used on sparc
, Alan Cox
, (Sun Oct 5, 9:24 am)
[PATCH 73/76] serial: fix device name reporting when minor ...
, Alan Cox
, (Sun Oct 5, 9:24 am)
[PATCH 74/76] tty: tty_io.c shadows sparse fix
, Alan Cox
, (Sun Oct 5, 9:25 am)
[PATCH 75/76] usb: fix pl2303 initialization
, Alan Cox
, (Sun Oct 5, 9:25 am)
[PATCH 76/76] ftdi: A few errors are err() that should be ...
, Alan Cox
, (Sun Oct 5, 9:25 am)
Re: [PATCH 38/76] tty: usb-serial krefs
, Greg KH
, (Sun Oct 5, 10:36 pm)
Re: [PATCH 67/76] tty: Remove lots of NULL checks
, Geert Uytterhoeven
, (Mon Oct 6, 1:58 am)
Re: [PATCH 38/76] tty: usb-serial krefs
, Alan Cox
, (Mon Oct 6, 2:02 am)
Re: [PATCH 26/76] tty: Add a kref count
, Louis Rilling
, (Mon Oct 6, 3:20 am)
Re: [PATCH 36/76] tty: Make get_current_tty use a kref
, Louis Rilling
, (Mon Oct 6, 3:35 am)
Re: [PATCH 67/76] tty: Remove lots of NULL checks
, Alan Cox
, (Mon Oct 6, 3:50 am)
Re: [PATCH 26/76] tty: Add a kref count
, Alan Cox
, (Mon Oct 6, 3:52 am)
Re: [PATCH 36/76] tty: Make get_current_tty use a kref
, Alan Cox
, (Mon Oct 6, 3:56 am)
Re: [PATCH 22/76] serial: Make uart_port's ioport "unsigne ...
, Josh Boyer
, (Mon Oct 6, 5:53 am)
Re: [PATCH 38/76] tty: usb-serial krefs
, Greg KH
, (Mon Oct 6, 9:13 pm)
Re: [PATCH 43/76] tty: Redo current tty locking
, Derek Fawcus
, (Thu Oct 9, 6:21 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Paul Turner
[tg_shares_up rewrite v4 11/11] sched: update tg->shares after cpu.shares write
Pete/Piet Delaney
Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure on powerpc
H. Peter Anvin
Re: [patch 0/2] Immediate Values - jump patching update
Adrian Bunk
2.6.23-rc3-mm1: m32r defconfig compile error
Hugh Dickins
Re: [PATCH -v8 3/4] Enable the MS_ASYNC functionality in sys_msync()
git
:
Han-Wen Nienhuys
Re: Cleaning up git user-interface warts
Brandon Casey
Re: [PATCH] git-relink: avoid hard linking in objects/info directory
Johannes Schindelin
Re: [PATCH] Documentation: config: add 'help.*' and 'instaweb.*' variables.
Steffen Prohaska
Re: best git practices, was Re: Git User's Survey 2007 unfinished summary continued
Felipe Contreras
Re: [PATCH v3 01/10] config: Codestyle cleanups.
git-commits-head
:
Linux Kernel Mailing List
ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
Linux Kernel Mailing List
vhost: Fix host panic if ioctl called with wrong index
Linux Kernel Mailing List
ACPI : Disable the device's ability to wake the sleeping system in the boot phase
Linux Kernel Mailing List
Staging: add poch driver
Linux Kernel Mailing List
Staging: epl: remove NEAR
linux-netdev
:
Marcel Holtmann
Re: [PATCH 1/1] iwmc3200: add more SDIO device ids
David Miller
Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Eric Dumazet
Re: TCP-MD5 checksum failure on x86_64 SMP
Jarek Poplawski
Re: rib_trie / Fix inflate_threshold_root. Now=15 size=11 bits
Ilpo Järvinen
Re: [RFC] TCP illinois max rtt aging
freebsd-current
:
Rui Paulo
802.11s (wireless mesh) project status report
Andrew Thompson
Re: Apparent moused regression since r189490
Aryeh Friedman
SATA and PATA drives are mutually exclusive
Robert Kent
Re: [HEADSUP] amd64 suspend/resume code to be comitted
Remko Lodder
[Fwd: Re: kern/118258 sysctl causing panics on 7.0-xxx]
Colocation donated by:
Syndicate