[PATCH 30/76] 8250: remove a few inlines of dubious value

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Date: Sunday, October 5, 2008 - 12:08 pm

From: \\\"Will Newton\\\" <will.newton@gmail.com>

Remove some inlines from various functions that are called once, are too
big to inline, or are called only from slow path code.  This saves around
300 bytes of code for me.

Signed-off-by: Will Newton <will.newton@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Alan Cox <alan@redhat.com>
---

 drivers/serial/8250.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 9f5e60d..e898edf 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -540,7 +540,7 @@ static unsigned int serial_icr_read(struct uart_8250_port *up, int offset)
 /*
  * FIFO support.
  */
-static inline void serial8250_clear_fifos(struct uart_8250_port *p)
+static void serial8250_clear_fifos(struct uart_8250_port *p)
 {
 	if (p->capabilities & UART_CAP_FIFO) {
 		serial_outp(p, UART_FCR, UART_FCR_ENABLE_FIFO);
@@ -555,7 +555,7 @@ static inline void serial8250_clear_fifos(struct uart_8250_port *p)
  * capability" bit enabled.  Note that on XR16C850s, we need to
  * reset LCR to write to IER.
  */
-static inline void serial8250_set_sleep(struct uart_8250_port *p, int sleep)
+static void serial8250_set_sleep(struct uart_8250_port *p, int sleep)
 {
 	if (p->capabilities & UART_CAP_SLEEP) {
 		if (p->capabilities & UART_CAP_EFR) {
@@ -1428,8 +1428,7 @@ static unsigned int check_modem_status(struct uart_8250_port *up)
 /*
  * This handles the interrupt from one port.
  */
-static inline void
-serial8250_handle_port(struct uart_8250_port *up)
+static void serial8250_handle_port(struct uart_8250_port *up)
 {
 	unsigned int status;
 	unsigned long flags;
@@ -1764,7 +1763,7 @@ static void serial8250_break_ctl(struct uart_port *port, int break_state)
 /*
  *	Wait for transmitter & holding register to empty
  */
-static inline void wait_for_xmitr(struct uart_8250_port *up, int bits)
+static void wait_for_xmitr(struct uart_8250_port *up, int bits)
 {
 	unsigned int status, tmout = 10000;
 

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/76] Queued TTY Patches, Alan Cox, (Sun Oct 5, 12:04 pm)
[PATCH 75/76] usb: fix pl2303 initialization, Alan Cox, (Sun Oct 5, 12:25 pm)
[PATCH 74/76] tty: tty_io.c shadows sparse fix, Alan Cox, (Sun Oct 5, 12:25 pm)
[PATCH 67/76] tty: Remove lots of NULL checks, Alan Cox, (Sun Oct 5, 12:23 pm)
Re: [PATCH 67/76] tty: Remove lots of NULL checks, Geert Uytterhoeven, (Mon Oct 6, 4:58 am)
[PATCH 66/76] tty: fix up gigaset a bit, Alan Cox, (Sun Oct 5, 12:23 pm)
[PATCH 63/76] tty: simplify ktermios allocation, Alan Cox, (Sun Oct 5, 12:22 pm)
[PATCH 62/76] pty: simplify unix98 allocation, Alan Cox, (Sun Oct 5, 12:22 pm)
[PATCH 60/76] pty: Coding style and polish, Alan Cox, (Sun Oct 5, 12:22 pm)
[PATCH 59/76] Simplify devpts_pty_kill, Alan Cox, (Sun Oct 5, 12:21 pm)
[PATCH 58/76] Simplify devpts_pty_new(), Alan Cox, (Sun Oct 5, 12:21 pm)
[PATCH 57/76] Simplify devpts_get_tty(), Alan Cox, (Sun Oct 5, 12:21 pm)
[PATCH 55/76] Move tty lookup/reopen to caller, Alan Cox, (Sun Oct 5, 12:21 pm)
[PATCH 52/76] tty: More driver operations, Alan Cox, (Sun Oct 5, 12:20 pm)
[PATCH 51/76] tty: kref the tty driver object, Alan Cox, (Sun Oct 5, 12:20 pm)
[PATCH 47/76] tty: shutdown method, Alan Cox, (Sun Oct 5, 12:18 pm)
[PATCH 46/76] vt: remove bogus lock dropping, Alan Cox, (Sun Oct 5, 12:18 pm)
[PATCH 43/76] tty: Redo current tty locking, Alan Cox, (Sun Oct 5, 12:15 pm)
Re: [PATCH 43/76] tty: Redo current tty locking, Derek Fawcus, (Thu Oct 9, 9:21 am)
[PATCH 42/76] tty: the vhangup syscall is racy, Alan Cox, (Sun Oct 5, 12:15 pm)
[PATCH 41/76] mxser: Switch to kref tty, Alan Cox, (Sun Oct 5, 12:14 pm)
[PATCH 40/76] stallion: Use krefs, Alan Cox, (Sun Oct 5, 12:13 pm)
[PATCH 39/76] tty: kref usage for isicom and moxa, Alan Cox, (Sun Oct 5, 12:12 pm)
[PATCH 38/76] tty: usb-serial krefs, Alan Cox, (Sun Oct 5, 12:11 pm)
Re: [PATCH 38/76] tty: usb-serial krefs, Greg KH, (Mon Oct 6, 1:36 am)
Re: [PATCH 38/76] tty: usb-serial krefs, Alan Cox, (Mon Oct 6, 5:02 am)
Re: [PATCH 38/76] tty: usb-serial krefs, Greg KH, (Tue Oct 7, 12:13 am)
Re: [PATCH 36/76] tty: Make get_current_tty use a kref, Louis Rilling, (Mon Oct 6, 6:35 am)
[PATCH 35/76] tty: compare the tty winsize, Alan Cox, (Sun Oct 5, 12:10 pm)
[PATCH 33/76] tty: Add termiox, Alan Cox, (Sun Oct 5, 12:09 pm)
[PATCH 32/76] tty: ipw need reworking, Alan Cox, (Sun Oct 5, 12:09 pm)
[PATCH 30/76] 8250: remove a few inlines of dubious value, Alan Cox, (Sun Oct 5, 12:08 pm)
[PATCH 29/76] Char: sx, fix io unmapping, Alan Cox, (Sun Oct 5, 12:08 pm)
[PATCH 28/76] Char: cyclades. remove bogus iomap, Alan Cox, (Sun Oct 5, 12:08 pm)
[PATCH 26/76] tty: Add a kref count, Alan Cox, (Sun Oct 5, 12:08 pm)
Re: [PATCH 26/76] tty: Add a kref count, Louis Rilling, (Mon Oct 6, 6:20 am)
Re: [PATCH 26/76] tty: Add a kref count, Alan Cox, (Mon Oct 6, 6:52 am)
[PATCH 19/76] ip2, init/deinit cleanup, Alan Cox, (Sun Oct 5, 12:07 pm)
[PATCH 18/76] ip2, fix sparse warnings, Alan Cox, (Sun Oct 5, 12:07 pm)
[PATCH 17/76] ip2, cleanup globals, Alan Cox, (Sun Oct 5, 12:06 pm)
[PATCH 16/76] Char: merge ip2main and ip2base, Alan Cox, (Sun Oct 5, 12:06 pm)
[PATCH 05/76] 8250: Remove NR_IRQ usage, Alan Cox, (Sun Oct 5, 12:05 pm)
[PATCH 04/76] epca: call tty_port_init, Alan Cox, (Sun Oct 5, 12:05 pm)