Re: 2.6.28-rc2 hates my e1000e

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Friday, October 31, 2008 - 8:44 am

On Fri, 31 Oct 2008, Linus Torvalds wrote:

And by "something like this", I obviously _really_ meant "something 
almost, but not entirely, unlike this".


The "insert_resource_expand_to_fit()" calling convention is much simpler, 
and it should be just

	insert_resource_expand_to_fit(&iomem_resource, res);

which has the downside (?) that it will actually _modify_ the resource as 
it expands it to fit. Of course, it's not like we don't do that in other 
places too (ie the "sanitize" phase), so I don't think it's much of a real 
downside.

Anyway, I'm not appending a fixed patch, becuase the fix is so trivial as 
to be more easily done by hand.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: 2.6.28-rc2 hates my e1000e, Robert Hancock, (Thu Oct 30, 5:45 pm)
Re: 2.6.28-rc2 hates my e1000e, Jonathan Corbet, (Thu Oct 30, 7:58 pm)
Re: 2.6.28-rc2 hates my e1000e, Yinghai Lu, (Thu Oct 30, 9:08 pm)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Fri Oct 31, 8:07 am)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Fri Oct 31, 8:44 am)
Re: 2.6.28-rc2 hates my e1000e, Jonathan Corbet, (Fri Oct 31, 9:00 am)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Fri Oct 31, 9:24 am)
Re: 2.6.28-rc2 hates my e1000e, Yinghai Lu, (Fri Oct 31, 9:35 am)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Fri Oct 31, 9:46 am)
Re: 2.6.28-rc2 hates my e1000e, Jonathan Corbet, (Fri Oct 31, 9:51 am)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Fri Oct 31, 9:58 am)
Re: 2.6.28-rc2 hates my e1000e, Yinghai Lu, (Fri Oct 31, 1:20 pm)
Re: 2.6.28-rc2 hates my e1000e, Jonathan Corbet, (Sat Nov 1, 8:01 am)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Sat Nov 1, 10:16 am)
Re: 2.6.28-rc2 hates my e1000e, Steven Rostedt, (Sat Nov 1, 10:35 am)
Re: 2.6.28-rc2 hates my e1000e, Yinghai Lu, (Sat Nov 1, 12:50 pm)
Re: 2.6.28-rc2 hates my e1000e, Jonathan Corbet, (Sat Nov 1, 3:45 pm)
Re: 2.6.28-rc2 hates my e1000e, Yinghai Lu, (Sat Nov 1, 3:47 pm)
Re: 2.6.28-rc2 hates my e1000e, Linus Torvalds, (Sat Nov 1, 4:18 pm)
Re: 2.6.28-rc2 hates my e1000e, Robert Hancock, (Sat Nov 1, 6:26 pm)