I finally got around to looking at the review notes.

On Sun, 26 Oct 2008, Randy Dunlap wrote:
quoted text
> >  
> >   # sysctl kernel.ftrace_enabled=1
> > - # echo ftrace > /debug/tracing/current_tracer
> > + # echo function > /debug/tracing/current_tracer
> >   # echo 1 > /debug/tracing/tracing_enabled
> >   # usleep 1
> >   # echo 0 > /debug/tracing/tracing_enabled
> >   # cat /debug/tracing/trace
> > -# tracer: ftrace
> > +# tracer: function
> >  #
> >  #           TASK-PID   CPU#    TIMESTAMP  FUNCTION
> >  #              | |      |          |         |
> 
> General comment #2: debugfs is normally mounted at /sys/kernel/debug
> (which Doc/x86/pat.txt, Doc/filesystems/relay.txt,
> Doc/infiniband/ipoib.txt, and Doc/usb/usbmon.txt know about).
> Please either use /sys/kernel/debug or use what Doc/kernel-parameters.txt
> uses: <debugfs> (for the mount point).  I.e., don't use a poor example
> in the doc text.

In the beginning of the document I did have a disclaimer:

------------------------
To mount the debugfs system:

  # mkdir /debug
  # mount -t debugfs nodev /debug

(Note: it is more common to mount at /sys/kernel/debug, but for simplicity
 this document will use /debug)
------------------------

I know the recommended place is /sys/kernel/debug, but I never use it. And 
I know many others that do not either. It is just easier to make the
/debug directory. I feel this is more of a guideline than something
that must be enforced.  But if you do feel strongly on this subject, I
can change it to /sys/kernel/debug (which I absolutely loathe).

The rest of your comments I'm fine with.

-- Steve
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/