Re: [patch] generic-ipi: fix the smp_mb() placement

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Jeremy Fitzhardinge

Subject: Re: [patch] generic-ipi: fix the smp_mb() placement

Date: Friday, October 31, 2008 - 4:12 am

Ingo Molnar wrote:
quoted text> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>   
>> Suresh Siddha wrote:
>>     
>>> We didn't see the lockup in our tests but Xen folks reported similar failures
>>> with their smp call function code.
>>>   
>>>       
>> ...really?  I don't remember anything like that, but perhaps I'm 
>> forgetting something.  In Xen the IPI is sent with a hypercall, 
>> which is definitely a solid enough barrier for these purposes.
>>     
>
> i think Suresh might be referring to some of the fragilities Xen had 
> with generic-ipi. But those AFAICT were due to the on-stack lifetime 
> bug that Nick fixed via the kmalloc? v2.6.26-ish issue.

Right, that's all I could think of.

    J
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch] generic-ipi: fix the smp_mb() placement, Suresh Siddha, (Wed Oct 29, 3:42 pm)

Re: [patch] generic-ipi: fix the smp_mb() placement, Jens Axboe, (Thu Oct 30, 12:20 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Suresh Siddha, (Thu Oct 30, 9:30 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Jens Axboe, (Thu Oct 30, 10:25 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Ingo Molnar, (Thu Oct 30, 11:53 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Suresh Siddha, (Thu Oct 30, 1:23 pm)

Re: [patch] generic-ipi: fix the smp_mb() placement, Jeremy Fitzhardinge, (Thu Oct 30, 10:10 pm)

Re: [patch] generic-ipi: fix the smp_mb() placement, Ingo Molnar, (Fri Oct 31, 2:39 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Jeremy Fitzhardinge, (Fri Oct 31, 4:12 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Suresh Siddha, (Fri Oct 31, 9:53 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Jeremy Fitzhardinge, (Fri Oct 31, 1:30 pm)

Re: [patch] generic-ipi: fix the smp_mb() placement, Ingo Molnar, (Mon Nov 3, 3:17 am)

Re: [patch] generic-ipi: fix the smp_mb() placement, Jeremy Fitzhardinge, (Mon Nov 3, 4:48 pm)

Re: [patch] generic-ipi: fix the smp_mb() placement, Ingo Molnar, (Tue Nov 4, 2:19 am)