Home » Mailing list archives » linux-kernel » 2008 » October » 3

Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jiri Kosina
Subject: Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:
Date: Friday, October 3, 2008 - 2:45 pm

On Fri, 3 Oct 2008, Jesse Barnes wrote:


Karsten has been testing kernel with these three patches from the series 
applied:

	e1000e: reset swflag after resetting hardware
	e1000e: fix lockdep issues
	e1000e: debug contention on NVM SWFLAG

This was done on a hardware which previously triggered the bug in just a 
few test iterations in quite a reliable way. Now, with these patches 
applied, the EEPROM corruption didn't happen after several tens of 
iterations.

Please note, that the patch that disables the writes to EEPROM on hardware 
level was *not* involved in this testing.

Therefore it currently seems that these three patches really address the 
race condition issue that was present in the e1000e driver.

It is still not clear why the bug started triggering all of a sudden for 
so many people though.

-- 
Jiri Kosina
SUSE Labs
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC PATCH 00/12] e1000e debug and protection patches, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 01/12] x86: export set_memory_ro and set_memory_rw, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 03/12] e1000e: reset swflag after resetting har ..., Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 04/12] e1000e: do not ever sleep in interrupt c ..., Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 05/12] e1000e: fix lockdep issues, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 06/12] e1000e: drop stats lock, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 08/12] e1000e: allow bad checksum, Jesse Brandeburg, (Mon Sep 29, 8:19 pm)
[RFC PATCH 09/12] e1000e: dump eeprom to dmesg for ich8/9, Jesse Brandeburg, (Mon Sep 29, 8:20 pm)
[RFC PATCH 10/12] e1000e: Use set_memory_ro()/set_memory_r ..., Jesse Brandeburg, (Mon Sep 29, 8:20 pm)
[RFC PATCH 11/12] e1000e: write protect ICHx NVM to preven ..., Jesse Brandeburg, (Mon Sep 29, 8:20 pm)
[RFC PATCH 12/12] update version, Jesse Brandeburg, (Mon Sep 29, 8:20 pm)
Re: [RFC PATCH 01/12] x86: export set_memory_ro and set_me ..., Ingo Molnar, (Tue Sep 30, 12:07 am)
Re: [RFC PATCH 08/12] e1000e: allow bad checksum, Jiri Kosina, (Tue Sep 30, 1:38 am)
Re: [RFC PATCH 11/12] e1000e: write protect ICHx NVM to pr ..., Jiri Kosina, (Tue Sep 30, 5:40 am)
RE: [RFC PATCH 11/12] e1000e: write protect ICHx NVM to pr ..., Allan, Bruce W, (Tue Sep 30, 8:47 am)
RE: [RFC PATCH 11/12] e1000e: write protect ICHx NVM to pr ..., Jiri Kosina, (Wed Oct 1, 6:29 am)
RE: [RFC PATCH 11/12] e1000e: write protect ICHx NVM to pr ..., Allan, Bruce W, (Wed Oct 1, 12:13 pm)
Re: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Jiri Kosina, (Thu Oct 2, 7:28 am)
Re: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Olaf Kirch, (Thu Oct 2, 8:03 am)
RE: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Brandeburg, Jesse, (Thu Oct 2, 9:27 am)
Re: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Olaf Kirch, (Thu Oct 2, 10:33 am)
RE: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Thomas Gleixner, (Thu Oct 2, 11:02 am)
Re: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Thomas Gleixner, (Thu Oct 2, 11:58 am)
Re: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Olaf Kirch, (Thu Oct 2, 12:07 pm)
Re: [RFC PATCH 07/12] e1000e: debug contention on NVM SWFLAG, Olaf Kirch, (Thu Oct 2, 12:08 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jesse Barnes, (Thu Oct 2, 3:23 pm)
[PATCH] e1000e: prevent concurrent access to NVRAM, Thomas Gleixner, (Thu Oct 2, 4:42 pm)
Re: [PATCH] e1000e: prevent concurrent access to NVRAM, Jesse Brandeburg, (Thu Oct 2, 5:19 pm)
Re: [PATCH] e1000e: prevent concurrent access to NVRAM, Thomas Gleixner, (Thu Oct 2, 5:28 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, David Miller, (Fri Oct 3, 1:46 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jesse Barnes, (Fri Oct 3, 2:29 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jiri Kosina, (Fri Oct 3, 2:45 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jesse Brandeburg, (Fri Oct 3, 4:28 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jesse Brandeburg, (Fri Oct 3, 4:30 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jiri Kosina, (Sat Oct 4, 3:21 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Thomas Gleixner, (Sat Oct 4, 4:02 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Jesse Brandeburg, (Sat Oct 4, 6:24 pm)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Thomas Gleixner, (Sun Oct 5, 1:51 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Arjan van de Ven, (Sun Oct 5, 8:05 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Thomas Gleixner, (Sun Oct 5, 8:55 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Arjan van de Ven, (Sun Oct 5, 9:02 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Thomas Gleixner, (Sun Oct 5, 9:16 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, Arjan van de Ven, (Sun Oct 5, 10:01 am)
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:, David Miller, (Tue Oct 7, 4:19 pm)