Re: ath9k: panic on tip/master

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Luis R. Rodriguez
Date: Friday, October 3, 2008 - 4:49 am

On Fri, Oct 03, 2008 at 11:09:31AM -0700, John W. Linville wrote:

Well Steven, please give this a shot, we think this is the culprit.

[PATCH] ath9k: fix oops on trying to hold the wrong spinlock

We were trying to hold the wrong spinlock due to a typo
on IEEE80211_BAR_CTL_TID_S's definition. We use this to
compute the tid number and then hold this this tid number's
spinlock during ath_bar_rx().

Signed-off-by: Vasanthakumar Thiagarajan <vasanth@atheros.com>
Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 drivers/net/wireless/ath9k/core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath9k/core.h b/drivers/net/wireless/ath9k/core.h
index 2f84093..88f4cc3 100644
--- a/drivers/net/wireless/ath9k/core.h
+++ b/drivers/net/wireless/ath9k/core.h
@@ -316,7 +316,7 @@ void ath_descdma_cleanup(struct ath_softc *sc,
 #define ATH_RX_TIMEOUT           40      /* 40 milliseconds */
 #define WME_NUM_TID              16
 #define IEEE80211_BAR_CTL_TID_M  0xF000  /* tid mask */
-#define IEEE80211_BAR_CTL_TID_S  2       /* tid shift */
+#define IEEE80211_BAR_CTL_TID_S  12      /* tid shift */
 
 enum ATH_RX_TYPE {
 	ATH_RX_NON_CONSUMED = 0,
-- 
1.5.6.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ath9k: panic on tip/master, Steven Noonan, (Fri Oct 3, 2:56 am)
Re: ath9k: panic on tip/master, Ingo Molnar, (Fri Oct 3, 3:02 am)
Re: ath9k: panic on tip/master, Luis R. Rodriguez, (Fri Oct 3, 4:49 am)
Re: ath9k: panic on tip/master, John W. Linville, (Fri Oct 3, 8:35 am)
Re: ath9k: panic on tip/master, John W. Linville, (Fri Oct 3, 11:09 am)