Home » Mailing list archives » linux-kernel » 2008 » October » 3

Re: [PATCH] dw_dmac: Fix copy/paste bug in tasklet

Previous thread: PROBLEM: processes claim CPU indefinitely on Intel(R) Core(TM)2 Quad by Reto Glauser on Tuesday, September 30, 2008 - 7:19 am. (1 message)

Next thread: [ksoftirqd/1] CPU reporting. by Jon Smirl on Tuesday, September 30, 2008 - 7:41 am. (3 messages)
[view original message]
From: Haavard Skinnemoen
Subject: [PATCH] dw_dmac: Fix copy/paste bug in tasklet
Date: Tuesday, September 30, 2008 - 7:27 am

The tasklet checks RAW.BLOCK twice, and does not check RAW.XFER. This is
obviously wrong, and could theoretically cause the driver to hang.

Reported-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
---
 drivers/dma/dw_dmac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 94df917..0778d99 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -364,7 +364,7 @@ static void dw_dma_tasklet(unsigned long data)
 	int i;
 
 	status_block = dma_readl(dw, RAW.BLOCK);
-	status_xfer = dma_readl(dw, RAW.BLOCK);
+	status_xfer = dma_readl(dw, RAW.XFER);
 	status_err = dma_readl(dw, RAW.ERROR);
 
 	dev_vdbg(dw->dma.dev, "tasklet: status_block=%x status_err=%x\n",
-- 
1.5.6.5

--


[ message continues ]
[view original message]
From: Andrew Morton
Subject: Re: [PATCH] dw_dmac: Fix copy/paste bug in tasklet
Date: Friday, October 3, 2008 - 2:26 am

We haven't heard from Dan for a week and this still wasn't in his tree
yesterday.

I think I'll cheerily send it in to Linus for 2.6.27.
--


[ message continues ]
[view original message]
From: Dan Williams
Subject: Re: [PATCH] dw_dmac: Fix copy/paste bug in tasklet
Date: Friday, October 3, 2008 - 8:39 am

Sorry for the non-response, I'll continue to be on vacation until the

Acked-by: Dan Williams <dan.j.williams@intel.com>
--


[ message continues ]
Previous thread: PROBLEM: processes claim CPU indefinitely on Intel(R) Core(TM)2 Quad by Reto Glauser on Tuesday, September 30, 2008 - 7:19 am. (1 message)

Next thread: [ksoftirqd/1] CPU reporting. by Jon Smirl on Tuesday, September 30, 2008 - 7:41 am. (3 messages)