Home » Mailing list archives » linux-kernel » 2008 » October » 3

Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton
Subject: Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation
Date: Friday, October 3, 2008 - 1:35 am

On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:


Violent objections.

We just don't know what this change will do.  It potentially affects
every code site in the kernel which looks at system_state.  We've had
problems in the past with this thing and the more complex we make it,
the worse any future problems will be.  It's Just Bad.

Can we just create a new global?

	extern bool system_entering_hibernation_or_whatever;

?

It'll add four bytes of bss, it'll save *more* than four bytes of
text and it is plainly obviously non-injurious to present and future
code.

hmm?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Regression: SATA disk double spin-off during hibernation o ..., Rafael J. Wysocki, (Thu Aug 28, 3:02 pm)
Re: Regression: SATA disk double spin-off during hibernati ..., Tejun Heo, (Fri Aug 29, 3:03 am)
Re: Regression: SATA disk double spin-off during hibernati ..., Rafael J. Wysocki, (Fri Aug 29, 3:41 am)
Re: Regression: SATA disk double spin-off during hibernati ..., Tejun Heo, (Fri Aug 29, 3:42 am)
[PATCH] SATA: Blacklist systems that spin off disks during ..., Rafael J. Wysocki, (Sat Sep 6, 10:23 am)
Re: [PATCH] SATA: Blacklist systems that spin off disks du ..., Tejun Heo, (Mon Sep 8, 4:38 am)
Re: [PATCH] SATA: Blacklist systems that spin off disks du ..., Jeff Garzik, (Sat Sep 13, 7:21 pm)
Re: [PATCH] SATA: Blacklist systems that spin off disks du ..., Rafael J. Wysocki, (Sun Sep 14, 5:00 pm)
Re: [PATCH] SATA: Blacklist systems that spin off disks du ..., Jeff Garzik, (Wed Sep 17, 2:50 pm)
[PATCH 0/6] SATA: Blacklist systems that spin off disks du ..., Rafael J. Wysocki, (Mon Sep 29, 3:06 pm)
[PATCH 1/6] Hibernation: Introduce new system state for th ..., Rafael J. Wysocki, (Mon Sep 29, 3:10 pm)
[PATCH 2/6] DMI: Introduce dmi_first_match to make the int ..., Rafael J. Wysocki, (Mon Sep 29, 3:13 pm)
[PATCH 3/6] SATA: Blacklisting of systems that spin off di ..., Rafael J. Wysocki, (Mon Sep 29, 3:14 pm)
[PATCH 4/6] SATA AHCI: Blacklist system that spins off dis ..., Rafael J. Wysocki, (Mon Sep 29, 3:15 pm)
[PATCH 5/6] SATA Sil: Blacklist system that spins off disk ..., Rafael J. Wysocki, (Mon Sep 29, 3:16 pm)
[PATCH 6/6] SATA PIIX: Blacklist system that spins off dis ..., Rafael J. Wysocki, (Mon Sep 29, 3:18 pm)
Re: [PATCH 2/6] DMI: Introduce dmi_first_match to make the ..., Tejun Heo, (Tue Sep 30, 8:31 pm)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Tejun Heo, (Tue Sep 30, 8:32 pm)
Re: [PATCH 3/6] SATA: Blacklisting of systems that spin of ..., Tejun Heo, (Tue Sep 30, 8:34 pm)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Rafael J. Wysocki, (Wed Oct 1, 4:36 am)
Re: [PATCH 3/6] SATA: Blacklisting of systems that spin of ..., Rafael J. Wysocki, (Wed Oct 1, 4:36 am)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Andrew Morton, (Fri Oct 3, 1:35 am)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Rafael J. Wysocki, (Fri Oct 3, 4:27 am)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Andrew Morton, (Fri Oct 3, 5:43 am)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Arjan van de Ven, (Fri Oct 3, 5:49 am)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Rafael J. Wysocki, (Fri Oct 3, 8:03 am)
Re: [PATCH 1/6] Hibernation: Introduce new system state fo ..., Rafael J. Wysocki, (Fri Oct 3, 8:05 am)
[PATCH 0/6] SATA: Blacklist systems that spin off disks du ..., Rafael J. Wysocki, (Fri Oct 3, 2:48 pm)
[PATCH 1/6] Hibernation: Introduce system_entering_hibernation, Rafael J. Wysocki, (Fri Oct 3, 2:51 pm)
[PATCH 2/6] DMI: Introduce dmi_first_match to make the int ..., Rafael J. Wysocki, (Fri Oct 3, 2:52 pm)
[PATCH 3/6] SATA: Blacklisting of systems that spin off di ..., Rafael J. Wysocki, (Fri Oct 3, 2:57 pm)
[PATCH 4/6] SATA AHCI: Blacklist system that spins off dis ..., Rafael J. Wysocki, (Fri Oct 3, 2:57 pm)
[PATCH 5/6] SATA Sil: Blacklist system that spins off disk ..., Rafael J. Wysocki, (Fri Oct 3, 2:58 pm)
[PATCH 6/6] SATA PIIX: Blacklist system that spins off dis ..., Rafael J. Wysocki, (Fri Oct 3, 2:58 pm)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Alan Cox, (Fri Oct 3, 4:27 pm)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Tejun Heo, (Sat Oct 4, 12:02 am)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Rafael J. Wysocki, (Sat Oct 4, 3:13 am)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Rafael J. Wysocki, (Sat Oct 4, 3:14 am)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Alan Cox, (Sat Oct 4, 2:50 pm)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Tejun Heo, (Sat Oct 4, 2:52 pm)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Tejun Heo, (Sat Oct 4, 3:27 pm)
Re: [PATCH 1/6] Hibernation: Introduce system_entering_hib ..., Rafael J. Wysocki, (Sat Oct 4, 3:30 pm)