Re: [PATCH] LOCKDEP: minor fix for debug_show_all_locks()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: qinghuang feng
Date: Tuesday, October 28, 2008 - 2:24 am

When we failed to get tasklist_lock eventually (count equals 0),
we should only print " ignoring it.\n", and not print
" locked it.\n" needlessly.

Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index dbda475..6533fd9 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -3417,8 +3417,7 @@ retry:
 		}
 		printk(" ignoring it.\n");
 		unlock = 0;
-	}
-	if (count != 10)
+	} else if (count != 10)
 		printk(" locked it.\n");

 	do_each_thread(g, p) {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] LOCKDEP: minor fix for debug_show_all_locks(), qinghuang feng, (Tue Oct 28, 2:24 am)