[PATCH RESEND]kgdb:remove redundant function invocation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Qinghuang Feng
Date: Saturday, October 25, 2008 - 9:59 am

Sorry for my resending, the previous patch can't be applied successfully.

It seems strange to call kgdboc_option_setup with parameter of config from 
configure_kgdboc(), because kgdboc_option_setup() is used to fill config
with stuff in other place. Now, kgdboc_option_setup will fill config
with config itself. But on the other hand, kgdboc_option_setup has a 
additional effect to check whether config overflows or not.

Is it ok to remove kgdboc_option_setup? 

Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/drivers/serial/kgdboc.c b/drivers/serial/kgdboc.c
index eadc1ab..03f683e 100644
--- a/drivers/serial/kgdboc.c
+++ b/drivers/serial/kgdboc.c
@@ -51,8 +51,7 @@ static int configure_kgdboc(void)
 	int tty_line = 0;
 	int err;
 
-	err = kgdboc_option_setup(config);
-	if (err || !strlen(config) || isspace(config[0]))
+	if (!strlen(config) || isspace(config[0]))
 		goto noconfig;
 
 	err = -ENODEV;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH RESEND]kgdb:remove redundant function invocation, Qinghuang Feng, (Sat Oct 25, 9:59 am)