Home » Mailing list archives » linux-kernel » 2008 » October » 2

Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const expressions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Rusty Russell <rusty@...>
To: Boaz Harrosh <bharrosh@...>
Cc: Ingo Molnar <mingo@...>, David S. Miller <davem@...>, Ivo van Doorn <IvDoorn@...>, John W. Linville <linville@...>, Alexey Dobriyan <adobriyan@...>, Andrew Morton <akpm@...>, Theodore Tso <tytso@...>, Linus Torvalds <torvalds@...>, Jan Beulich <jbeulich@...>, linux-kernel <linux-kernel@...>
Subject: Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const expressions
Date: Thursday, October 2, 2008 - 1:35 am

On Wednesday 03 September 2008 01:57:31 Boaz Harrosh wrote:

Why did you hate the void cast again?  Simplest should 
be "(void)BUILD_BUG_ON_ZERO(e)".  But if not, it seems to me that it's 
cleaner to do:

#define BUILD_BUG_ON(e) \
	do { } while(BUILD_BUG_ON_ZERO(e))

No chance of the compiler emitting unused vars.

Cheers,
Rusty.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions, Boaz Harrosh, (Mon Sep 1, 9:00 am)
Re: [PATCHSET 0/5] BUILD_BUG_ON: error on none-const express..., Ingo Molnar, (Sat Sep 6, 12:01 pm)
[PATCH 5/5] debug: BUILD_BUG_ON: error on non-const expressi..., Boaz Harrosh, (Mon Sep 1, 9:28 am)
Re: [PATCH 5/5 ver3] debug: BUILD_BUG_ON: error on non-const..., Boaz Harrosh, (Tue Sep 2, 12:07 pm)
[PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const exp..., Boaz Harrosh, (Tue Sep 2, 11:57 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Rusty Russell, (Thu Oct 2, 1:35 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Boaz Harrosh, (Sun Oct 5, 5:34 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Jan Beulich, (Tue Sep 2, 12:11 pm)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Boaz Harrosh, (Wed Sep 3, 4:57 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Jan Beulich, (Wed Sep 3, 6:19 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Boaz Harrosh, (Wed Sep 3, 6:52 am)
Re: [PATCH 5/5 ver2] debug: BUILD_BUG_ON: error on non-const..., Boaz Harrosh, (Tue Sep 2, 12:06 pm)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const exp..., Jan Beulich, (Mon Sep 1, 9:55 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const exp..., Boaz Harrosh, (Mon Sep 1, 10:21 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const ex..., Jan Beulich, (Mon Sep 1, 10:36 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const ex..., Boaz Harrosh, (Mon Sep 1, 11:00 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const e..., Jan Beulich, (Mon Sep 1, 11:29 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const e..., Boaz Harrosh, (Mon Sep 1, 12:41 pm)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const exp..., Jan Beulich, (Tue Sep 2, 3:47 am)
Re: [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const exp..., Boaz Harrosh, (Tue Sep 2, 11:19 am)
[PATCH 4/5] rt2x00: Compiler warning unmasked by fix of BUIL..., Boaz Harrosh, (Mon Sep 1, 9:21 am)
[PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fix of..., Boaz Harrosh, (Tue Sep 2, 11:55 am)
[PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fix of..., Boaz Harrosh, (Mon Sep 1, 9:44 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fi..., Ivo Van Doorn, (Mon Sep 1, 10:01 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fi..., Boaz Harrosh, (Mon Sep 1, 11:17 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fi..., Ivo van Doorn, (Mon Sep 1, 12:34 pm)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fi..., Boaz Harrosh, (Tue Sep 2, 10:20 am)
Re: [PATCH 4/5 ver2] rt2x00: Compiler warning unmasked by fi..., Ivo van Doorn, (Tue Sep 2, 10:27 am)
Re: [PATCH 4/5] rt2x00: Compiler warning unmasked by fix of ..., Benny Halevy, (Mon Sep 1, 9:27 am)
Re: [PATCH 4/5] rt2x00: Compiler warning unmasked by fix of ..., Ivo Van Doorn, (Mon Sep 1, 9:27 am)
[PATCH 3/5] virtio: Fix none-const BUILD_BUG_ON usage, Boaz Harrosh, (Mon Sep 1, 9:13 am)
[PATCH 3/5 ver2] virtio: Fix non-const BUILD_BUG_ON usage, Boaz Harrosh, (Tue Sep 2, 11:53 am)
[PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage, Boaz Harrosh, (Mon Sep 1, 9:11 am)
[PATCH] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUN..., Boaz Harrosh, (Mon Sep 1, 9:07 am)