[bug report] sched: stop_machine() usage causes load balancer to misbehave

Previous thread: [PATCH] xen: remove unused balloon.h by Jeremy Fitzhardinge on Thursday, October 2, 2008 - 4:42 pm. (2 messages)

Next thread: [RFC/PATCH] Block device for the ISS simulator by Benjamin Herrenschmidt on Thursday, October 2, 2008 - 5:08 pm. (6 messages)
From: Chris Friesen
Date: Thursday, October 2, 2008 - 4:57 pm

I mentioned before that ftrace (specifically the ftraced daemon) seems 
to be interfering with the load balancer.  After some experimenting, it 
appears that any regular calls to stop_machine() will end up confusing 
the load balancer.

As an experiment, I disabled ftraced (which would normally result in 
correct load balancing) but added a single kernel thread which simply 
runs the following loop, where "chrisd2" is a dummy function.

while(1) {
	set_current_state(TASK_INTERRUPTIBLE);
	schedule_timeout(HZ);
	stop_machine(chrisd2, NULL, NULL);
}

With the modified kernel, my testcase shows that the load balancer 
doesn't balance--all tasks remain on one cpu while the other one stays idle.

Most of the users of stop_machine() (kprobes on s390, cpu hotplug, 
module load/unload, numa_zonelist_order, etc.) don't seem to be called 
on a regular basis.  Only ftrace behaves this way, which is why it 
appeared to be the source of the problem.

I haven't tracked down the specific reasons for the misbehaviour, but it 
seems undesirable.

Anyone have any ideas what might be causing this?  Is it a problem with 
the load balancer, or an unavoidable consequence of what stop_machine() 
is doing?

Thanks,

Chris
--

From: Steven Rostedt
Date: Thursday, October 2, 2008 - 5:02 pm

Chris,

Thanks for looking into this. I don't have an answer for your question, 
but I'll work harder to get the MCOUNT_REC working in PPC.

Does this happen with x86 too?

-- Steve
--

From: Chris Friesen
Date: Friday, October 3, 2008 - 10:27 pm

Unfortunately I don't have an x86 box handy for testing...I could 
probably get some time on a lab machine next week.

Chris
--

Previous thread: [PATCH] xen: remove unused balloon.h by Jeremy Fitzhardinge on Thursday, October 2, 2008 - 4:42 pm. (2 messages)

Next thread: [RFC/PATCH] Block device for the ISS simulator by Benjamin Herrenschmidt on Thursday, October 2, 2008 - 5:08 pm. (6 messages)