[ kernel people added to Cc ]
Thanks for your report.
I missed this since the kernel sys_getdents() did not use the
"struct dirent" from the header but an own "struct linux_dirent".
It might be safe since the LTP tests don't seem to care whether
getdents() returns nonsense.
But it is not correct since the reason why I removed this struct from
the userspace headers was that the kernel and libc structs are
*different*.
E.g. when I enable the commented out code in getdents01.c I get the
expected result that using <dirent.h> instead of <linux/dirent.h>
changes a PASS into a FAIL. [1]
IMHO the solution is something like:
- move "struct linux_dirent" from fs/readdir.c to include/linux/dirent.h
- re-export linux/dirent.h to userspace
- change getdents(2) to consistently use "struct linux_dirent"
Questions to fsdevel:
- Do we need to preserve API compatibility with compatibility #define's
for struct dirent{,64} here?
- LTP does malloc(sizeof(struct dirent)).
cu
Adrian
[1] I don't know whether the code is valid and guaranteed to pass,
but it's obvious why it fails after the #include change
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
--
