[PATCH] ring-buffer: fix build error

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Steven Rostedt <rostedt@...>
Cc: Linus Torvalds <torvalds@...>, Peter Zijlstra <peterz@...>, Jonathan Corbet <corbet@...>, Mathieu Desnoyers <compudj@...>, LKML <linux-kernel@...>, Thomas Gleixner <tglx@...>, Andrew Morton <akpm@...>, <prasad@...>, Frank Ch. Eigler <fche@...>, David Wilder <dwilder@...>, <hch@...>, Martin Bligh <mbligh@...>, Christoph Hellwig <hch@...>, Masami Hiramatsu <mhiramat@...>, Steven Rostedt <srostedt@...>, Arnaldo Carvalho de Melo <acme@...>
Date: Thursday, October 2, 2008 - 5:05 am

* Ingo Molnar <mingo@elte.hu> wrote:


trivial build fix below.

	Ingo

From 339ce9af3e6cbc02442b0b356c1ecb80a8ae92fb Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 2 Oct 2008 11:04:14 +0200
Subject: [PATCH] ring-buffer: fix build error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

fix:

 kernel/trace/ring_buffer.c: In function ‘rb_allocate_pages’:
 kernel/trace/ring_buffer.c:235: error: ‘cpu’ undeclared (first use in this function)
 kernel/trace/ring_buffer.c:235: error: (Each undeclared identifier is reported only once
 kernel/trace/ring_buffer.c:235: error: for each function it appears in.)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/trace/ring_buffer.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 9814571..54a3098 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -232,7 +232,7 @@ static int rb_allocate_pages(struct ring_buffer_per_cpu *cpu_buffer,
 
 	for (i = 0; i < nr_pages; i++) {
 		page = kzalloc_node(ALIGN(sizeof(*page), cache_line_size()),
-				    GFP_KERNEL, cpu_to_node(cpu));
+				    GFP_KERNEL, cpu_to_node(i));
 		if (!page)
 			goto free_pages;
 		list_add(&page->list, &pages);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC PATCH 1/2 v3] Unified trace buffer, Steven Rostedt, (Thu Sep 25, 2:51 pm)
[RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Thu Sep 25, 9:02 pm)
Re: [RFC PATCH v4] Unified trace buffer, Masami Hiramatsu, (Thu Sep 25, 9:52 pm)
[PATCH v5] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 1:11 pm)
[PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 2:05 pm)
Re: [PATCH v6] Unified trace buffer, Arnaldo Carvalho de Melo, (Fri Sep 26, 6:31 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 7:58 pm)
Re: [PATCH v6] Unified trace buffer, Linus Torvalds, (Fri Sep 26, 8:13 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 8:23 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 8:28 pm)
[PATCH v7] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:13 pm)
[PATCH v8] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 10:02 pm)
[PATCH v9] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 2:06 am)
[PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 12:10 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Mathieu Desnoyers, (Mon Sep 29, 7:35 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 8:01 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Mathieu Desnoyers, (Mon Sep 29, 8:03 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 8:12 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Mathieu Desnoyers, (Mon Sep 29, 11:46 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 12:00 am)
Re: [PATCH v10 Golden] Unified trace buffer, Jonathan Corbet, (Tue Sep 30, 11:20 am)
Re: [PATCH v10 Golden] Unified trace buffer, Peter Zijlstra, (Tue Sep 30, 11:54 am)
Re: [PATCH v10 Golden] Unified trace buffer, Linus Torvalds, (Tue Sep 30, 12:38 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 12:48 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Peter Zijlstra, (Tue Sep 30, 1:00 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 1:41 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Peter Zijlstra, (Tue Sep 30, 1:49 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 1:56 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Tue Sep 30, 2:02 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Linus Torvalds, (Tue Sep 30, 1:01 pm)
[PATCH] ring_buffer: allocate buffer page pointer, Steven Rostedt, (Wed Oct 1, 11:14 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Andrew Morton, (Thu Oct 2, 5:06 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Steven Rostedt, (Thu Oct 2, 9:06 am)
[PATCH] ring-buffer: fix build error, Ingo Molnar, (Thu Oct 2, 5:05 am)
[PATCH] ring_buffer: map to cpu not page, Steven Rostedt, (Thu Oct 2, 7:18 pm)
Re: [PATCH] ring_buffer: map to cpu not page, Ingo Molnar, (Fri Oct 3, 3:27 am)
[PATCH] x86 Topology cpu_to_node parameter check, Mathieu Desnoyers, (Fri Oct 3, 12:56 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Steven Rostedt, (Fri Oct 3, 1:20 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Mathieu Desnoyers, (Fri Oct 3, 11:56 am)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Steven Rostedt, (Fri Oct 3, 12:26 pm)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Mathieu Desnoyers, (Fri Oct 3, 1:21 pm)
Re: [PATCH] x86 Topology cpu_to_node parameter check, Steven Rostedt, (Fri Oct 3, 1:54 pm)
[PATCH] topology.h define mess fix, Mathieu Desnoyers, (Fri Oct 3, 2:53 pm)
RE: [PATCH] topology.h define mess fix, Luck, Tony, (Fri Oct 3, 4:14 pm)
[PATCH] topology.h define mess fix v2, Mathieu Desnoyers, (Fri Oct 3, 6:47 pm)
Re: [PATCH] ring_buffer: map to cpu not page, Steven Rostedt, (Thu Oct 2, 7:36 pm)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Steven Rostedt, (Thu Oct 2, 9:17 am)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Steven Rostedt, (Thu Oct 2, 2:27 pm)
Re: [boot crash] Re: [PATCH] ring-buffer: fix build error, Steven Rostedt, (Thu Oct 2, 9:16 am)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Mathieu Desnoyers, (Wed Oct 1, 2:21 pm)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Mathieu Desnoyers, (Wed Oct 1, 1:36 pm)
Re: [PATCH] ring_buffer: allocate buffer page pointer, Steven Rostedt, (Wed Oct 1, 1:49 pm)
Re: [PATCH v10 Golden] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 12:11 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 2:39 pm)
Re: [PATCH v9] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 3:24 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 3:41 pm)
Re: [PATCH v9] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 3:54 pm)
Re: [PATCH v9] Unified trace buffer, Martin Bligh, (Sat Sep 27, 4:07 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 4:34 pm)
Re: [PATCH v9] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 4:00 pm)
Re: [PATCH v9] Unified trace buffer, Steven Rostedt, (Mon Sep 29, 11:05 am)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 4:08 pm)
Re: [PATCH v6] Unified trace buffer, Masami Hiramatsu, (Fri Sep 26, 5:14 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:26 pm)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 3:17 pm)
Re: [PATCH v6] Unified trace buffer, Arjan van de Ven, (Fri Sep 26, 7:16 pm)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 3:14 pm)
Re: [PATCH v6] Unified trace buffer, Mike Travis, (Fri Sep 26, 6:28 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 7:56 pm)
Re: [PATCH v6] Unified trace buffer, Mike Travis, (Fri Sep 26, 8:05 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 8:18 pm)
Re: [PATCH v6] Unified trace buffer, Mike Travis, (Fri Sep 26, 8:46 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 8:52 pm)
Re: [PATCH v6] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 2:59 pm)
Re: [PATCH v6] Unified trace buffer, Martin Bligh, (Fri Sep 26, 3:46 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 5:37 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 3:52 pm)
Re: [PATCH v6] Unified trace buffer, Richard Holden, (Fri Sep 26, 2:30 pm)
Re: [PATCH v6] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 2:39 pm)
Re: [PATCH v5] Unified trace buffer, Arnaldo Carvalho de Melo, (Fri Sep 26, 1:31 pm)
Re: [PATCH v5] Unified trace buffer, Linus Torvalds, (Fri Sep 26, 1:37 pm)
Re: [PATCH v5] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 1:46 pm)
Re: [PATCH v5] Unified trace buffer, Ingo Molnar, (Sat Sep 27, 1:02 pm)
Re: [PATCH v5] Unified trace buffer, Steven Rostedt, (Sat Sep 27, 1:18 pm)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Thu Sep 25, 10:11 pm)
Re: [RFC PATCH v4] Unified trace buffer, Mathieu Desnoyers, (Thu Sep 25, 11:20 pm)
Re: [RFC PATCH v4] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 3:18 am)
Re: [RFC PATCH v4] Unified trace buffer, Mathieu Desnoyers, (Fri Sep 26, 12:04 pm)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 6:47 am)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 6:45 am)
Re: [RFC PATCH v4] Unified trace buffer, Peter Zijlstra, (Fri Sep 26, 7:00 am)
Re: [RFC PATCH v4] Unified trace buffer, Masami Hiramatsu, (Fri Sep 26, 12:57 pm)
Re: [RFC PATCH v4] Unified trace buffer, Steven Rostedt, (Fri Sep 26, 1:14 pm)
Re: [RFC PATCH v4] Unified trace buffer, Masami Hiramatsu, (Thu Sep 25, 10:47 pm)