[PATCH RESEND] MAX3100 SPI UART driver

Previous thread: make MAINTAINERS slightly easier to search by Pavel Machek on Thursday, October 2, 2008 - 1:14 am. (7 messages)

Next thread: Re: [Linux-fbdev-devel] [PATCH] matroxfb: Support G200eV chip by krzysztof.h1 on Thursday, October 2, 2008 - 2:29 am. (2 messages)
From: Christian Pellegrin
Date: Thursday, October 2, 2008 - 1:39 am

This patch adds support for the MAX3100 SPI UART. I am still
waiting for a minor number from device@lanana.org so that
may change.

Generated on  20081002  against v2.6.27-rc7

Signed-off-by: Christian Pellegrin <chripell@fsfe.org>
---
 drivers/serial/Kconfig         |    6 +-
 drivers/serial/Makefile        |    1 +
 drivers/serial/max3100.c       |  924 ++++++++++++++++++++++++++++++++++++++++
 include/linux/serial_core.h    |    3 +
 include/linux/serial_max3100.h |   53 +++
 5 files changed, 986 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 77cb342..de3193d 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -509,7 +509,11 @@ config SERIAL_S3C2440
 	help
 	  Serial port support for the Samsung S3C2440 and S3C2442 SoC
 
-
+config SERIAL_MAX3100
+        tristate "MAX3100 support"
+        depends on SPI
+        help
+          MAX3100 chip support
 
 config SERIAL_DZ
 	bool "DECstation DZ serial driver"
diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
index 7e7383e..21c3daf 100644
--- a/drivers/serial/Makefile
+++ b/drivers/serial/Makefile
@@ -31,6 +31,7 @@ obj-$(CONFIG_SERIAL_S3C2400) += s3c2400.o
 obj-$(CONFIG_SERIAL_S3C2410) += s3c2410.o
 obj-$(CONFIG_SERIAL_S3C2412) += s3c2412.o
 obj-$(CONFIG_SERIAL_S3C2440) += s3c2440.o
+obj-$(CONFIG_SERIAL_MAX3100) += max3100.o
 obj-$(CONFIG_SERIAL_SUNCORE) += suncore.o
 obj-$(CONFIG_SERIAL_SUNHV) += sunhv.o
 obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o
diff --git a/drivers/serial/max3100.c b/drivers/serial/max3100.c
new file mode 100644
index 0000000..7a269a6
--- /dev/null
+++ b/drivers/serial/max3100.c
@@ -0,0 +1,924 @@
+/*
+ *
+ *  Copyright (C) 2008 Christian Pellegrin <chripell@evolware.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your ...
From: Andrew Morton
Date: Wednesday, October 8, 2008 - 2:26 pm

On Thu,  2 Oct 2008 10:39:13 +0200

Both Alan and I had numerous review comments on the previous version of
this patch.

You have not sent us a point-by-point response to those review comments
which forces us to a) go back and see what all the comments were then
b) check the patch to see if/how each point was addressed.  Needless to
say, that's not a ton of fun for us.

Can you please reply to our earlier emails and let us know what changes
were made against each review comment?

Thanks.

--

From: chri
Date: Wednesday, October 8, 2008 - 10:44 pm

On Wed, Oct 8, 2008 at 11:26 PM, Andrew Morton


Sorry again for the misunderstanding.

Bye,

-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."
--

From: Andrew Morton
Date: Friday, January 9, 2009 - 3:21 pm

On Thu,  2 Oct 2008 10:39:13 +0200



Meanwhile, other people have gone and added new minors in there anyway.

I think I'll just merge it:



From: Christian Pellegrin <chripell@gmail.com>

Add support for the MAX3100 SPI UART.

(akpm: queued pending confirmation of the new major number)

[randy.dunlap@oracle.com: select SERIAL_CORE]
Signed-off-by: Christian Pellegrin <chripell@fsfe.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
max3100 driver need to select SERIAL_CORE like most other serial drivers do.
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/Kconfig         |    7 
 drivers/serial/Makefile        |    1 
 drivers/serial/max3100.c       |  927 +++++++++++++++++++++++++++++++
 include/linux/serial_core.h    |    3 
 include/linux/serial_max3100.h |   53 +
 5 files changed, 991 insertions(+)

diff -puN drivers/serial/Kconfig~max3100-spi-uart-driver drivers/serial/Kconfig
--- a/drivers/serial/Kconfig~max3100-spi-uart-driver
+++ a/drivers/serial/Kconfig
@@ -533,6 +533,13 @@ config SERIAL_S3C6400
 	  Serial port support for the Samsung S3C6400 and S3C6410
 	  SoCs
 
+config SERIAL_MAX3100
+	tristate "MAX3100 support"
+	depends on SPI
+	select SERIAL_CORE
+	help
+	  MAX3100 chip support
+
 config SERIAL_DZ
 	bool "DECstation DZ serial driver"
 	depends on MACH_DECSTATION && 32BIT
diff -puN drivers/serial/Makefile~max3100-spi-uart-driver drivers/serial/Makefile
--- a/drivers/serial/Makefile~max3100-spi-uart-driver
+++ a/drivers/serial/Makefile
@@ -43,6 +43,7 @@ obj-$(CONFIG_SERIAL_S3C2412) += s3c2412.
 obj-$(CONFIG_SERIAL_S3C2440) += s3c2440.o
 obj-$(CONFIG_SERIAL_S3C24A0) += s3c24a0.o
 obj-$(CONFIG_SERIAL_S3C6400) += s3c6400.o
+obj-$(CONFIG_SERIAL_MAX3100) += max3100.o
 obj-$(CONFIG_SERIAL_IP22_ZILOG) += ip22zilog.o
 obj-$(CONFIG_SERIAL_MUX) += mux.o
 obj-$(CONFIG_SERIAL_68328) += 68328serial.o
diff -puN /dev/null drivers/serial/max3100.c
--- /dev/null
+++ a/drivers/serial/max3100.c
@@ -0,0 +1,927 @@
+/*
+ *
+ *  ...
From: christian pellegrin
Date: Saturday, January 10, 2009 - 11:49 am

On Fri, Jan 9, 2009 at 11:21 PM, Andrew Morton

Hello,

I'm sorry. I asked two times following all the instructions in
devices.txt (or at least trying to do so) without any response. I hope
I didn't do something wrong. :-/

Thanks,

-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."
--

Previous thread: make MAINTAINERS slightly easier to search by Pavel Machek on Thursday, October 2, 2008 - 1:14 am. (7 messages)

Next thread: Re: [Linux-fbdev-devel] [PATCH] matroxfb: Support G200eV chip by krzysztof.h1 on Thursday, October 2, 2008 - 2:29 am. (2 messages)