Re: [PATCH 1/1] block: installing include/linux/blktrace_api.h

Previous thread: [PATCH 1/1] block: installing include/linux/blktrace_api.h by John Jolly on Wednesday, September 24, 2008 - 7:42 am. (1 message)

Next thread: [kernel-abi] symbol versioning vs. out-of-tree modules. by Paweł on Wednesday, September 24, 2008 - 8:07 am. (16 messages)
From: John Jolly
Date: Wednesday, September 24, 2008 - 7:47 am

From: John Jolly <jjolly@novell.com>

Added line to install include/linux/blktrace_api.h during 'make headers_install'

Signed-off-by: John Jolly <jjolly@novell.com>
CC: Jan Blunck <JBlunck@novell.com>
---
 include/linux/Kbuild |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index b68ec09..f1e5fa1 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -41,6 +41,7 @@ header-y += baycom.h
 header-y += bfs_fs.h
 header-y += blkpg.h
 header-y += bpqether.h
+header-y += blktrace_api.h
 header-y += can.h
 header-y += cdk.h
 header-y += chio.h
--

From: Andrew Morton
Date: Wednesday, October 1, 2008 - 11:11 pm

The two basic and almost always necessary parts of a patch changelog are

a) what was changed and

b) why the change was made

Your changelog had no b), hence nobody is likely to apply the patch.
--

From: Jens Axboe
Date: Wednesday, October 1, 2008 - 11:38 pm

A similar patch is already merged for 2.6.28 as well.

-- 
Jens Axboe

--

Previous thread: [PATCH 1/1] block: installing include/linux/blktrace_api.h by John Jolly on Wednesday, September 24, 2008 - 7:42 am. (1 message)

Next thread: [kernel-abi] symbol versioning vs. out-of-tree modules. by Paweł on Wednesday, September 24, 2008 - 8:07 am. (16 messages)