Home » Mailing list archives » linux-kernel » 2008 » October » 18

[patch 14/14] x86: work around MTRR mask setting, v2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH
Subject: [patch 14/14] x86: work around MTRR mask setting, v2
Date: Saturday, October 18, 2008 - 11:57 am

2.6.25-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Ingo Molnar <mingo@elte.hu>

commit 9754a5b840a209bc1f192d59f63e81b698a55ac8 upstream

improve the debug printout:

- make it actually display something
- print it only once

would be nice to have a WARN_ONCE() facility, to feed such things to
kerneloops.org.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: S.Çağlar Onur <caglar@pardus.org.tr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 arch/x86/kernel/cpu/mtrr/generic.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -251,7 +251,12 @@ static void generic_get_mtrr(unsigned in
 		tmp |= ~((1<<(hi - 1)) - 1);
 
 		if (tmp != mask_lo) {
-			WARN_ON("mtrr: your BIOS has set up an incorrect mask, fixing it up.\n");
+			static int once = 1;
+
+			if (once) {
+				printk(KERN_INFO "mtrr: your BIOS has set up an incorrect mask, fixing it up.\n");
+				once = 0;
+			}
 			mask_lo = tmp;
 		}
 	}

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 00/14] 2.6.25-stable review, Greg KH, (Sat Oct 18, 11:56 am)
[patch 01/14] x86: Reserve FIRST_DEVICE_VECTOR in used_vec ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 02/14] x86: improve UP kernel when CPU-hotplug and ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 03/14] x86, early_ioremap: fix fencepost error, Greg KH, (Sat Oct 18, 11:57 am)
[patch 04/14] tty: Termios locking - sort out real_tty con ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 05/14] sched_rt.c: resch needed in rt_rq_enqueue() ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 06/14] CIFS: make sure we have the right resume inf ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 07/14] b43legacy: Fix failure in rate-adjustment me ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 08/14] fbcon_set_all_vcs: fix kernel crash when swi ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 09/14] hwmon: (it87) Prevent power-off on Shuttle S ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 10/14] Dont allow splice() to files opened with O_A ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 11/14] V4L: bttv: Prevent NULL pointer dereference ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 12/14] V4L: zr36067: Fix RGBR pixel format, Greg KH, (Sat Oct 18, 11:57 am)
[patch 13/14] drm/i915: fix ioremap of a user address for ..., Greg KH, (Sat Oct 18, 11:57 am)
[patch 14/14] x86: work around MTRR mask setting, v2, Greg KH, (Sat Oct 18, 11:57 am)