Home » Mailing list archives » linux-kernel » 2008 » October » 15

[PATCH vfs-2.6 4/6] vfs: remove unnecessary fsnotify_d_instantiate()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: OGAWA Hirofumi
Subject: [PATCH vfs-2.6 4/6] vfs: remove unnecessary fsnotify_d_instantiate()
Date: Wednesday, October 15, 2008 - 3:50 pm

This calls d_move(), so fsnotify_d_instantiate() is unnecessary like
rename path.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---

 fs/dcache.c |    1 -
 1 file changed, 1 deletion(-)

diff -puN fs/dcache.c~dcache-cleanup-4 fs/dcache.c
--- vfs-2.6/fs/dcache.c~dcache-cleanup-4	2008-10-16 06:57:33.000000000 +0900
+++ vfs-2.6-hirofumi/fs/dcache.c	2008-10-16 06:57:33.000000000 +0900
@@ -1210,7 +1210,6 @@ struct dentry *d_splice_alias(struct ino
 		new = __d_find_alias(inode, 1);
 		if (new) {
 			BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED));
-			fsnotify_d_instantiate(new, inode);
 			spin_unlock(&dcache_lock);
 			security_d_instantiate(new, inode);
 			d_rehash(dentry);
_
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH vfs-2.6 1/6] vfs: replace parent == dentry-&gt;d_paren ..., OGAWA Hirofumi, (Wed Oct 15, 3:50 pm)
[PATCH vfs-2.6 3/6] vfs: add __d_instantiate() helper, OGAWA Hirofumi, (Wed Oct 15, 3:50 pm)
[PATCH vfs-2.6 2/6] vfs: add d_ancestor(), OGAWA Hirofumi, (Wed Oct 15, 3:50 pm)
[PATCH vfs-2.6 6/6] vfs: add LOOKUP_RENAME_TARGET intent, OGAWA Hirofumi, (Wed Oct 15, 3:50 pm)
[PATCH vfs-2.6 5/6] vfs: remove LOOKUP_PARENT from non LOO ..., OGAWA Hirofumi, (Wed Oct 15, 3:50 pm)
[PATCH vfs-2.6 4/6] vfs: remove unnecessary fsnotify_d_ins ..., OGAWA Hirofumi, (Wed Oct 15, 3:50 pm)
Re: [PATCH vfs-2.6 6/6] vfs: add LOOKUP_RENAME_TARGET intent, Andrew Morton, (Thu Oct 16, 3:29 pm)
Re: [PATCH vfs-2.6 6/6] vfs: add LOOKUP_RENAME_TARGET intent, OGAWA Hirofumi, (Thu Oct 16, 4:30 pm)