Home » Mailing list archives » linux-kernel » 2008 » October » 15

Re: GIT head no longer boots on x86-64

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jiri Slaby
Subject: Re: GIT head no longer boots on x86-64
Date: Wednesday, October 15, 2008 - 8:33 am

On 10/15/2008 05:06 PM, Linus Torvalds wrote:

Not in my eyes.


Modules area is vmalloc'ed on x86; on x86_64 only in different virtual address
space area. So returning true from is_vmalloc_addr() for this space looks very
sane to me, as it was on x86_32 for years.

Users usually do
is_vmalloc_addr(a) ? vfree(a) : kfree(a);
Even there it makes more sense to me.

However I'm fine with introducing is_module_addr() alike function for x86 to
check the general modules space bounds on x86_64 and return is_vmalloc_addr() on
x86_32. Does this look better?
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
GIT head no longer boots on x86-64, Alan Cox, (Mon Oct 13, 2:23 am)
Re: GIT head no longer boots on x86-64, Jiri Slaby, (Mon Oct 13, 3:13 am)
Re: GIT head no longer boots on x86-64, Alan Cox, (Mon Oct 13, 3:20 am)
Re: GIT head no longer boots on x86-64, Jiri Slaby, (Mon Oct 13, 3:56 am)
Re: GIT head no longer boots on x86-64, Alan Cox, (Mon Oct 13, 6:35 am)
Re: GIT head no longer boots on x86-64, Linus Torvalds, (Mon Oct 13, 7:45 am)
Re: GIT head no longer boots on x86-64, Jiri Slaby, (Mon Oct 13, 7:50 am)
Re: GIT head no longer boots on x86-64, Linus Torvalds, (Mon Oct 13, 8:03 am)
Re: GIT head no longer boots on x86-64, Jiri Slaby, (Mon Oct 13, 8:11 am)
Re: GIT head no longer boots on x86-64, Alan Cox, (Mon Oct 13, 8:47 am)
Re: GIT head no longer boots on x86-64, Ingo Molnar, (Wed Oct 15, 4:51 am)
Re: GIT head no longer boots on x86-64, Jiri Slaby, (Wed Oct 15, 6:19 am)
Re: GIT head no longer boots on x86-64, Linus Torvalds, (Wed Oct 15, 8:06 am)
Re: GIT head no longer boots on x86-64, Jiri Slaby, (Wed Oct 15, 8:33 am)
Re: GIT head no longer boots on x86-64, Linus Torvalds, (Wed Oct 15, 8:35 am)
Re: GIT head no longer boots on x86-64, Linus Torvalds, (Wed Oct 15, 9:01 am)
Re: GIT head no longer boots on x86-64, Arjan van de Ven, (Wed Oct 15, 1:31 pm)
Re: GIT head no longer boots on x86-64, H. Peter Anvin, (Thu Oct 16, 3:31 am)