Re: [PATCH 09/23] Staging: add me4000 pci data collection driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Wednesday, October 15, 2008 - 1:41 am

> On Fri, 10 Oct 2008 15:42:33 -0700 Greg KH <greg@kroah.com> wrote:

- sort includes (include/linux before asm/)

- Make me4000_board_info_list static


Reorder includes (inxlude/linux before include/asm)


static


s/= 0//


kill


lots of these are unneeded.


probably lots of those too.


blah


wtf


yet another home-made circular buffer implementation

rename all struct foo_t to struct foo


	.foo = bar,


dittoes


ditto


static


unneeded initialisation


Yet another home-made prdebug?


crazy label indenting


locking for me4000_board_info_list


me4000_regbase and me4000_regbase_size should become resource_size_t.



dittoes


kzalloc


kzalloc


__func__(?)


kfree(NULL) is legal


etc


kzalloc()


etc


etc


ho hum


__func__


indent


this doesn't do anything

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] STAGING patches for 2.6.28, Greg KH, (Fri Oct 10, 3:41 pm)
[PATCH 04/23] Staging: add MAINTAINERS entry, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 05/23] Staging: add et131x network driver, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 12/23] Staging: USB/IP: add client driver, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 13/23] Staging: USB/IP: add host driver, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 14/23] Staging: add w35und wifi driver, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 17/23] Staging: Fix gcc warnings in sxg, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 18/23] Staging: go7007 v4l fixes, Greg KH, (Fri Oct 10, 3:42 pm)
[PATCH 23/23] Staging: Lindent sxg.c, Greg KH, (Fri Oct 10, 3:42 pm)
Re: [PATCH 16/23] Staging: add echo cancelation module, Mike Frysinger, (Fri Oct 10, 4:08 pm)
Re: [PATCH 16/23] Staging: add echo cancelation module, Tzafrir Cohen, (Fri Oct 10, 11:33 pm)
Re: [GIT PATCH] STAGING patches for 2.6.28, Greg KH, (Mon Oct 13, 2:36 pm)
[PATCH 25/25] staging: at76_usb wireless driver, Greg KH, (Mon Oct 13, 2:38 pm)
Re: [PATCH 25/25] staging: at76_usb wireless driver, Pavel Roskin, (Mon Oct 13, 2:49 pm)
Re: [PATCH 25/25] staging: at76_usb wireless driver, Pavel Roskin, (Mon Oct 13, 2:58 pm)
Re: [PATCH 09/23] Staging: add me4000 pci data collection ..., Andrew Morton, (Wed Oct 15, 1:41 am)
Re: [GIT PATCH] STAGING patches for 2.6.28, Linus Torvalds, (Fri Oct 17, 1:34 pm)
Re: [GIT PATCH] STAGING patches for 2.6.28, Greg KH, (Fri Oct 17, 2:38 pm)
Re: [GIT PATCH] STAGING patches for 2.6.28, Greg KH, (Fri Oct 17, 3:00 pm)
Re: [PATCH 14/23] Staging: add w35und wifi driver, Geert Uytterhoeven, (Sat Oct 18, 1:55 pm)