Home » Mailing list archives » linux-kernel » 2008 » October » 14

Re: linux-next: origin tree build failure

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds
Subject: Re: linux-next: origin tree build failure
Date: Tuesday, October 14, 2008 - 4:51 pm

On Wed, 15 Oct 2008, Stephen Rothwell wrote:

Btw, as to why not do this idiocy, just grep for it.

We have several drivers that try to do something this stupid. Don't take 
my word for it? Look for them. And see them do things like

 - drivers/scsi/arm/fas216.h:

	#ifndef NO_IRQ
	#define NO_IRQ 255
	#endif

 - drivers/pcmcia/pd6729.c (really interesting):

	#ifndef NO_IRQ
	#define NO_IRQ  ((unsigned int)(0))
	#endif

 - drivers/rtc/rtc-m48t59.c:

	#ifndef NO_IRQ
	#define NO_IRQ  (-1)
	#endif

so please don't add yet another version to the insanity. Just mark 
anything with NO_IRQ as BROKEN or ARM-specific, or something.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
linux-next: origin tree build failure, Stephen Rothwell, (Tue Oct 14, 3:59 pm)
Re: linux-next: origin tree build failure, Linus Torvalds, (Tue Oct 14, 4:43 pm)
Re: linux-next: origin tree build failure, Linus Torvalds, (Tue Oct 14, 4:51 pm)
Re: linux-next: origin tree build failure, David Miller, (Tue Oct 14, 4:52 pm)
Re: linux-next: origin tree build failure, Mark Brown, (Tue Oct 14, 5:05 pm)
Re: linux-next: origin tree build failure, Linus Torvalds, (Tue Oct 14, 5:34 pm)
Re: linux-next: origin tree build failure, Alan Cox, (Wed Oct 15, 2:02 am)
Re: linux-next: origin tree build failure, Ingo Molnar, (Wed Oct 15, 2:33 am)
Re: linux-next: origin tree build failure, Mark Brown, (Wed Oct 15, 4:01 am)