Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory support.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Monday, October 13, 2008 - 8:20 pm

Christoph Hellwig <hch@infradead.org> writes:


Chistoph, your comments and Al's would have been much more productive
if you have had said:

"I didn't like sysfs because it doesn't do things the way other filesystems
  with similar problems do things.  Can you please use common idioms?
  Making the code easier to read and making the code easier to maintain.
  Some of those constructs look awfully complex can you recheck you code
  and see if there is a simpler way to implement them."

That would have been honest and productive.  As it sits.  I have partially
inaccurate feedback from Al, useless feedback from you, and only my own
tough skin and determination to keep me going..

The fact that you and Al look at the code and can't easily make sense of
is a good sign that the code as written will be hard to maintain.  Al's
recent breakage of sysctl is a good example of that.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Thu Jun 26, 1:21 pm)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Mon Jun 30, 11:56 am)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Tue Jul 1, 12:50 am)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Tue Jul 1, 2:20 am)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Tue Jul 1, 5:30 am)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Tue Jul 1, 8:53 pm)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Wed Jul 2, 9:49 am)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Wed Jul 2, 10:11 pm)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Thu Jul 3, 5:27 am)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Thu Jul 3, 12:57 pm)
Re: [PATCH 06/11] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Thu Jul 3, 1:08 pm)
[PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Thu Jul 3, 5:48 pm)
[PATCH 02/15] sysfs: Support for preventing unmounts., Eric W. Biederman, (Thu Jul 3, 6:07 pm)
[PATCH 03/15] sysfs: sysfs_get_dentry add a sb parameter, Eric W. Biederman, (Thu Jul 3, 6:08 pm)
[PATCH 04/15] sysfs: Implement __sysfs_get_dentry, Eric W. Biederman, (Thu Jul 3, 6:09 pm)
[PATCH 05/15] sysfs: Rename Support multiple superblocks, Eric W. Biederman, (Thu Jul 3, 6:10 pm)
[PATCH 06/15] Introduce sysfs_sd_setattr and fix sysfs_chmod, Eric W. Biederman, (Thu Jul 3, 6:11 pm)
[PATCH 08/15] sysfs: Make sysfs_mount static once again., Eric W. Biederman, (Thu Jul 3, 6:14 pm)
Re: [PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Thu Jul 3, 6:27 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Fri Jul 4, 6:31 am)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Fri Jul 4, 2:49 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Fri Jul 4, 3:00 pm)
Re: [PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Sat Jul 5, 9:42 pm)
Re: [PATCH 00/15] sysfs support for namespaces, Cornelia Huck, (Mon Jul 7, 4:41 am)
Re: [PATCH 00/15] sysfs support for namespaces, Eric W. Biederman, (Mon Jul 7, 5:22 am)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Sun Jul 13, 6:54 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Tue Jul 15, 10:41 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Tue Jul 15, 11:32 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Wed Jul 16, 12:07 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Wed Jul 16, 2:09 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Fri Jul 18, 1:19 pm)
Re: [PATCH 12/15] driver core: Implement tagged directory ..., Eric W. Biederman, (Sat Aug 2, 11:59 pm)
Re: [PATCH 09/15] sysfs: Implement sysfs tagged directory ..., Eric W. Biederman, (Tue Aug 19, 11:58 pm)
[PATCH 0/8] sysfs namespace support, Eric W. Biederman, (Wed Aug 20, 11:31 pm)
[PATCH 1/8] sysfs: Implement sysfs tagged directory support., Eric W. Biederman, (Wed Aug 20, 11:33 pm)
[PATCH 2/8] sysfs: Merge sysfs_rename_dir and sysfs_move_dir, Eric W. Biederman, (Wed Aug 20, 11:34 pm)
[PATCH 3/8] sysfs: Implement sysfs_delete_link and sysfs_r ..., Eric W. Biederman, (Wed Aug 20, 11:35 pm)
[PATCH 5/8] sysfs: Remove sysfs_create_link_nowarn, Eric W. Biederman, (Wed Aug 20, 11:36 pm)
Re: [PATCH 0/8] sysfs namespace support, David Miller, (Wed Aug 20, 11:37 pm)
[PATCH 4/8] driver core: Implement tagged directory suppor ..., Eric W. Biederman, (Wed Aug 20, 11:37 pm)
[PATCH 7/8] netns: Enable tagging for net_class directorie ..., Eric W. Biederman, (Wed Aug 20, 11:39 pm)
[PATCH 8/8] sysfs: user namespaces: fix bug with clone(CLO ..., Eric W. Biederman, (Wed Aug 20, 11:40 pm)
Re: [PATCH 1/8] sysfs: Implement sysfs tagged directory su ..., Eric W. Biederman, (Mon Oct 13, 8:20 pm)