Cc: Greg KH <gregkh@...>, Mark Ryden <markryde@...>, Benjamin Thery <benjamin.thery@...>, David Shwatrz <dshwatrz@...>, Greg KH <greg@...>, Andrew Morton <akpm@...>, Tejun Heo <htejun@...>, Daniel Lezcano <dlezcano@...>, <linux-kernel@...>, Al Viro <viro@...>, Linux Containers <containers@...>, <netdev@...>
Chistoph, your comments and Al's would have been much more productive
if you have had said:
"I didn't like sysfs because it doesn't do things the way other filesystems
with similar problems do things. Can you please use common idioms?
Making the code easier to read and making the code easier to maintain.
Some of those constructs look awfully complex can you recheck you code
and see if there is a simpler way to implement them."
That would have been honest and productive. As it sits. I have partially
inaccurate feedback from Al, useless feedback from you, and only my own
tough skin and determination to keep me going..
The fact that you and Al look at the code and can't easily make sense of
is a good sign that the code as written will be hard to maintain. Al's
recent breakage of sysctl is a good example of that.
Eric
--
