login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
October
»
13
Re: [PATCH] pata_of_platform: fix no irq handling
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Benjamin Herrenschmidt
Subject:
Re: [PATCH] pata_of_platform: fix no irq handling
Date: Monday, October 13, 2008 - 4:27 pm
On Mon, 2008-10-13 at 15:56 +0900, Tejun Heo wrote:
quoted text
> Anton Vorontsov wrote: > > When no irq specified the pata_of_platform fills the irq_res with -1, > > which is wrong to do for two reasons: > > > > 1. By definition, 'no irq' should be IRQ 0, not some negative integer; > > 2. pata_platform checks for irq_res.start > 0, but since irq_res.start > > is unsigned type, the check will be true for `-1'. > > > > Reported-by: Steven A. Falco <sfalco@harris.com> > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > applied to #tj-upstream (will soon be sent upstream)
Hrm... I applied it to powerpc.git too :-) Hopefully the merge will sort it out ! Cheers, Ben. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] pata_of_platform: fix no irq handling
, Anton Vorontsov
, (Mon Oct 6, 10:26 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Matt Sealey
, (Mon Oct 6, 1:41 pm)
Re: [PATCH] pata_of_platform: fix no irq handling
, Anton Vorontsov
, (Mon Oct 6, 2:32 pm)
Re: [PATCH] pata_of_platform: fix no irq handling
, Tejun Heo
, (Mon Oct 6, 6:30 pm)
Re: [PATCH] pata_of_platform: fix no irq handling
, Wang Jian
, (Tue Oct 7, 2:18 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Anton Vorontsov
, (Tue Oct 7, 2:26 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Alan Cox
, (Tue Oct 7, 2:37 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Benjamin Herrenschmidt
, (Tue Oct 7, 3:04 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, David Woodhouse
, (Wed Oct 8, 1:40 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Alan Cox
, (Wed Oct 8, 2:00 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Geert Uytterhoeven
, (Wed Oct 8, 2:59 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Alan Cox
, (Wed Oct 8, 3:27 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Paul Mundt
, (Fri Oct 10, 10:55 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Tejun Heo
, (Sun Oct 12, 11:56 pm)
Re: [PATCH] pata_of_platform: fix no irq handling
, Jeff Garzik
, (Mon Oct 13, 6:27 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Tejun Heo
, (Mon Oct 13, 6:53 am)
Re: I have returned!
, Alan Cox
, (Mon Oct 13, 7:02 am)
[PATCH] fusion: remove dead mpt lan code
, Alan Cox
, (Mon Oct 13, 7:04 am)
[PATCH] mptsas: remove pointless null check
, Alan Cox
, (Mon Oct 13, 7:05 am)
Re: [PATCH] mptsas: remove pointless null check
, James Bottomley
, (Mon Oct 13, 7:22 am)
Re: [PATCH] mptsas: remove pointless null check
, Alan Cox
, (Mon Oct 13, 7:37 am)
Re: [PATCH] pata_of_platform: fix no irq handling
, Benjamin Herrenschmidt
, (Mon Oct 13, 4:27 pm)
Re: I have returned!
, Jeff Garzik
, (Thu Oct 16, 2:40 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 041/196] kobject: add kobject_init_and_add function
Lukas Hejtmanek
Re: Another libata error related to OCZ SSD
Greg Kroah-Hartman
[PATCH 023/196] MCP_UCB1200: Convert from class_device to device
Florian Fainelli
Re: System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade
Christoph Lameter
[patch 1/4] mmu_notifier: Core code
git
:
Johannes Schindelin
Re: [PATCH 1/2] Add strbuf_initf()
John Bito
[EGIT] Push to GitHub caused corruption
Jakub Narebski
Re: [PATCH 0/2] gitweb: patch view
Junio C Hamano
Re: [PATCH] When a remote is added but not fetched, tell the user.
Andy Parkins
Re: [RFC] Submodules in GIT
git-commits-head
:
Linux Kernel Mailing List
ahci: Workaround HW bug for SB600/700 SATA controller PMP support
Linux Kernel Mailing List
V4L/DVB (11086): au0828: rename macro for currently non-function VBI support
Linux Kernel Mailing List
ceph: client types
Linux Kernel Mailing List
ceph: on-wire types
Linux Kernel Mailing List
crypto: chainiv - Use kcrypto_wq instead of keventd_wq
linux-netdev
:
Andrew Morton
Re: [Bugme-new] [Bug 14969] New: b44: WOL does not work in suspended state
Giuseppe CAVALLARO
Re: [PATCH 03/13] stmmac: add the new Header file for stmmac platform data
Taku Izumi
[PATCH 3/3] ixgbe: add registers etc. printout code just before resetting adapters
Eric Dumazet
rps: some comments
Thomas Gleixner
Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:
openbsd-misc
:
Stephan Andreas
problems with login after xlock in OpenBSD release 4.7
pmc
Make A Change. Alcoholism and Drug Addiction Treatment
ropers
Re: what exactly is enc0?
Fuad NAHDI
Re: What does your environment look like?
Matthew Szudzik
Typo on OpenBSD 4.4 CD Set
Colocation donated by:
Syndicate