Re: [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Monday, October 13, 2008 - 1:36 am

>  	if (--hp->count == 0) {

I will try. Of course the risk here is that the interrupt happens
after we set hp->tty to NULL, so we probably need to check within the
interrupt handler for a NULL tty. I haven't checked if that's the case
(I'm not in front of the code right now).

Ben.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC 0/3]: hvc_console rework for platform without hard irqs, Christian Borntraeger, (Tue Jun 3, 5:44 am)
[RFC 1/3] hvc_console: rework setup to replace irq functi ..., Christian Borntraeger, (Tue Jun 3, 5:45 am)
[RFC 2/3] virtio_console: use virtqueue notification for h ..., Christian Borntraeger, (Tue Jun 3, 5:46 am)
[RFC 3/3] s390: use virtio_console for KVM on s390, Christian Borntraeger, (Tue Jun 3, 5:46 am)
[RFC 1/3] hvc_console: rework setup to replace irq functio ..., Christian Borntraeger, (Tue Jun 3, 5:49 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Christian Borntraeger, (Wed Jun 4, 1:00 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Benjamin Herrenschmidt, (Wed Jun 4, 2:06 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fu ..., Christian Borntraeger, (Wed Jun 4, 4:15 am)
[RFC 1/3 v2] hvc_console: rework setup to replace irq func ..., Christian Borntraeger, (Fri Jun 20, 6:24 am)
[RFC 2/3 v2] virtio_console: use virtqueue notification fo ..., Christian Borntraeger, (Fri Jun 20, 6:24 am)
[RFC 3/3 v2] s390: use virtio_console for KVM on s390, Christian Borntraeger, (Fri Jun 20, 6:24 am)
Re: [RFC 3/3 v2] s390: use virtio_console for KVM on s390, Rusty Russell, (Sun Jun 22, 8:04 pm)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Benjamin Herrenschmidt, (Sun Oct 12, 10:16 pm)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Christian Borntraeger, (Mon Oct 13, 12:51 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Benjamin Herrenschmidt, (Mon Oct 13, 1:36 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Christian Borntraeger, (Mon Oct 13, 1:47 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Benjamin Herrenschmidt, (Mon Oct 13, 2:52 am)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Benjamin Herrenschmidt, (Mon Oct 13, 5:38 pm)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Christian Borntraeger, (Mon Oct 13, 11:42 pm)
Re: [RFC 1/3] hvc_console: rework setup to replace irq fun ..., Benjamin Herrenschmidt, (Tue Oct 14, 1:18 am)